You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/11/19 18:31:26 UTC
[GitHub] ccollins476ad commented on a change in pull request #232: Use
syscfg settings for sysinit stage numbers
ccollins476ad commented on a change in pull request #232: Use syscfg settings for sysinit stage numbers
URL: https://github.com/apache/mynewt-nimble/pull/232#discussion_r234731983
##########
File path: nimble/host/mesh/pkg.yml
##########
@@ -45,5 +45,5 @@ pkg.req_apis:
- stats
pkg.init:
- bt_mesh_register_gatt: 500
- ble_mesh_shell_init: 1000
+ bt_mesh_register_gatt: 'MYNEWT_VAL(BLE_MESH_SYSINIT_STAGE)'
+ ble_mesh_shell_init: 'MYNEWT_VAL(BLE_MESH_SYSINIT_STAGE_2)'
Review comment:
Thanks, @rymanluk. I agree that `BLE_MESH_SYSINIT_STAGE_2` is a poor name.
I renamed it to `BLE_MESH_SYSINIT_STAGE_SHELL` rather than your suggestion of `BLE_MESH_SHELL_SYSINIT_STAGE`. I don't have a preference either way, but I already chose this arbitrary convention for other packages with multiple sysinit stages.
I pushed this commit separately with the intent to fixup before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services