You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by "Malte S. Stretz" <ms...@gmx.net> on 2005/02/10 22:48:48 UTC
Re: svn commit: r153294 - spamassassin/trunk/build/do
On Thursday 10 February 2005 22:30 CET quinlan@apache.org wrote:
>[...]
> # Check if the source is a symlink and read the target. On systems
> which do # not support symlinks, readlink will bail out which is catched
> by the eval, # similar to what 'perldoc -f symlink' suggests. It will
> fall back to copy # then.
> -$lnk = eval { readlink($src) };
> -if ($@) {
> - $cmd = 'copy' if ($cmd eq 'symlink');
> +if ($cmd eq 'symlink' && !SYMLINK) {
> + $cmd = 'copy';
> }
Ummm... now the whole logic is broken. The readlink() was there for a
reason...
Cheers,
Malte
--
[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
<http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
<http://www.catb.org/~esr/faqs/smart-questions.html>