[GitHub] zheng-da commented on a change in pull request #10215: [WIP] Fix race condition when mixing MKLDNN ops with sparse ops

[GitBox <gi...@apache.org>]

zheng-da commented on a change in pull request #10215: [WIP] Fix race condition when mixing MKLDNN ops with sparse ops
URL: https://github.com/apache/incubator-mxnet/pull/10215#discussion_r176630238
 
 

 ##########
 File path: tests/python/unittest/test_sparse_operator.py
 ##########
 @@ -1820,6 +1820,21 @@ def check_scatter_ops(name, shape, lhs_stype, rhs_stype, forward_mxnet_call, for
                           lambda l, r: l + r,
                           rhs_is_scalar=True, verbose=False, density=0.5)
 
+@with_seed()
+def test_mkldnn_sparse():
+    # This test is trying to create a race condition describedd in
 
 Review comment:
   this test can't produce the race condition. actually, the race condition we think may happen actually can't happen with the current implementation of sparse operators. I may need to wait until the sparse operators are fixed.
   
   I created this PR because I want to address https://github.com/apache/incubator-mxnet/issues/10189. I already have implemented a solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services