Re: Unsubscribe

[Greg Stein <gs...@gmail.com>]

You can unsubscribe yourself by emailing:
dev-unsubscribe@neatbeans.incubator.apache.org

On Mon, Dec 4, 2017 at 12:27 PM, Carlos Otiniano Osorio <
888.carlos@gmail.com> wrote:

> Unsubscribe please.
>
> 2017-12-04 12:58 GMT-05:00 GitBox <gi...@apache.org>:
>
>> dtrebbien commented on a change in pull request #317: Excluding svnkit
>> URL: https://github.com/apache/incubator-netbeans/pull/317#discus
>> sion_r154725660
>>
>>
>>
>>  ##########
>>  File path: subversion/src/org/netbeans/modules/subversion/options/SvnOp
>> tionsController.java
>>  ##########
>>  @@ -97,7 +98,12 @@ public Component getListCellRendererComponent (JList
>> list, Object value, int ind
>>                  return super.getListCellRendererComponent(list, value,
>> index, isSelected, cellHasFocus);
>>              }
>>          });
>> -        panel.cmbPreferredClient.setModel(new DefaultComboBoxModel(new
>> Object[] { panel.panelCLI, panel.panelJavahl, panel.panelSvnkit }));
>> +        List<JPanel> clients = new ArrayList<>();
>> +        clients.addAll(Arrays.asList(panel.panelCLI,
>> panel.panelJavahl));
>> +        if (SvnClientFactory.hasSvnKit()) {
>> +            clients.add(panel.panelSvnkit);
>> +        }
>> +        panel.cmbPreferredClient.setModel(new
>> DefaultComboBoxModel(clients.toArray(new Object[0])));
>>
>>  Review comment:
>>    Maybe toArray() should be used here?
>>
>>    I have submitted PR #318.
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>> With regards,
>> Apache Git Services
>>
>
>