You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xicm (via GitHub)" <gi...@apache.org> on 2023/10/19 09:38:43 UTC
[PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
xicm opened a new pull request, #9886:
URL: https://github.com/apache/hudi/pull/9886
…om.index.use.metadata
### Change Logs
When we load column ranges from meta table in BLOOM index, we should use `_hoodie_record_key` rather than `hoodie.datasource.write.recordkey.field` .
### Impact
none
### Risk level (write none, low medium or high below)
low
### Documentation Update
none
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1772181552
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
}, {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "1771980280",
"triggerType" : "MANUAL"
}, {
"hash" : "9456e57d5d87ce8e2db946c03b2075e2d45b6826",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9456e57d5d87ce8e2db946c03b2075e2d45b6826",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3e2763136ca7108adc32162d093abb58b143363 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394)
* 9456e57d5d87ce8e2db946c03b2075e2d45b6826 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.bloom.index.use.metadata [hudi]
Posted by "ad1happy2go (via GitHub)" <gi...@apache.org>.
ad1happy2go commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1778808955
@danny0405 This is actually more related to https://github.com/apache/hudi/issues/9870
I confirmed also, this one fixes the duplicates issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1771987931
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
}, {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "1771980280",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c3e2763136ca7108adc32162d093abb58b143363 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1770725347
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3e2763136ca7108adc32162d093abb58b143363 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.bloom.index.use.metadata [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1776827912
The related issue: https://github.com/apache/hudi/issues/9857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1770456561
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3e2763136ca7108adc32162d093abb58b143363 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.bloom.index.use.metadata [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1786873864
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1771984196
> Is the `_hoodie_record_key` field always there, I see many test failures.
I run the failed test locally, it is successful.
I think another thing, if the col-stats field is user provided, should we add meta field to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1770442820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1772665871
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
}, {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "1771980280",
"triggerType" : "MANUAL"
}, {
"hash" : "9456e57d5d87ce8e2db946c03b2075e2d45b6826",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20419",
"triggerID" : "9456e57d5d87ce8e2db946c03b2075e2d45b6826",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9456e57d5d87ce8e2db946c03b2075e2d45b6826 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20419)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1771927902
Is the `_hoodie_record_key` field always there, I see many test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1772233448
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
}, {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "1771980280",
"triggerType" : "MANUAL"
}, {
"hash" : "9456e57d5d87ce8e2db946c03b2075e2d45b6826",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20419",
"triggerID" : "9456e57d5d87ce8e2db946c03b2075e2d45b6826",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3e2763136ca7108adc32162d093abb58b143363 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394)
* 9456e57d5d87ce8e2db946c03b2075e2d45b6826 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20419)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1771980996
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
}, {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1771980280",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c3e2763136ca7108adc32162d093abb58b143363 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.bloom.index.use.metadata [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1780419088
Nice catch @xicm ,
We may need to check whether 'config.getColumnsEnabledForColumnStatsIndex()' contains the `hoodie.table.recordkey.fields` field,
- if 'config.getColumnsEnabledForColumnStatsIndex()' is empty，that means all the fields(including the metadata fields)are indexed in col_stats，then we can still use `hoodie.table.recordkey.fields` (caution that if `hoodie.table.recordkey.fields` is not configured，we can fallback to `_hoodie_record_key`）;
- if not empty，we need to check whether `hoodie.table.recordkey.fields` is included in the col_stats，use it if if `hoodie.table.recordkey.fields` is included and throws exception otherwise.
It's great if we can supplement some test cases that mentioned in https://github.com/apache/hudi/issues/9870 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.bloom.index.use.metadata [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9886:
URL: https://github.com/apache/hudi/pull/9886#discussion_r1377054672
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/HoodieBloomIndex.java:
##########
@@ -212,7 +212,7 @@ protected List<Pair<String, BloomIndexFileInfo>> loadColumnRangesFromMetaIndex(
// also obtain file ranges, if range pruning is enabled
context.setJobStatus(this.getClass().getName(), "Load meta index key ranges for file slices: " + config.getTableName());
- String keyField = hoodieTable.getMetaClient().getTableConfig().getRecordKeyFieldProp();
+ String keyField = HoodieRecord.HoodieMetadataField.RECORD_KEY_METADATA_FIELD.getFieldName();
Review Comment:
Do you think we need to throw exception if `config.getColumnsEnabledForColumnStatsIndex()` does not contain the record keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.bloom.index.use.metadata [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9886:
URL: https://github.com/apache/hudi/pull/9886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1770532388
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3e2763136ca7108adc32162d093abb58b143363",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394",
"triggerID" : "c3e2763136ca7108adc32162d093abb58b143363",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3e2763136ca7108adc32162d093abb58b143363 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20394)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6946] Data Duplicates with range pruning while using hoodie.blo… [hudi]
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1771980280
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org