You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/10/21 22:41:38 UTC
Review Request 39523: GEODE-370: Using SerialDistributionMessage for
serializers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39523/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
DataSerializers were being sent using PooledDistributionMessage. That
meant they could be processed out of order. When DataSerializers were
added out of order to a client queue, some serializers would be lost.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java 09f9280f5ac26f034ce3456f0c490451bf82beb5
Diff: https://reviews.apache.org/r/39523/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 39523: GEODE-370: Using SerialDistributionMessage
for serializers
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39523/#review103478
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Oct. 21, 2015, 1:41 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39523/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 1:41 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> DataSerializers were being sent using PooledDistributionMessage. That
> meant they could be processed out of order. When DataSerializers were
> added out of order to a client queue, some serializers would be lost.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java 09f9280f5ac26f034ce3456f0c490451bf82beb5
>
> Diff: https://reviews.apache.org/r/39523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 39523: GEODE-370: Using SerialDistributionMessage
for serializers
Posted by Dan Smith <ds...@pivotal.io>.
> On Oct. 21, 2015, 8:57 p.m., Darrel Schneider wrote:
> > It might be worthwhile to track down when this message was made a Pooled message instead of Serial.
> > The Instantiator code has a corresponding message and it is Serial already. It makes me wonder if we
> > had a bug long ago with DataSerializers jamming up the serial executor and it was fixed by changing this
> > to a Pooled message.
I tracked it down to "initial implementation of DataSerializableFixedID" by Darrel Schneider :)
On the other hand, some lazy fellow named Dan Smith changed the InternalInstantiator.RegistrationMessage to be a SerialDistributionMessage to fix a suspiciously similar bug. If only he had thought to look at InternalDataSerializer!
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39523/#review103471
-----------------------------------------------------------
On Oct. 21, 2015, 8:41 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39523/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 8:41 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> DataSerializers were being sent using PooledDistributionMessage. That
> meant they could be processed out of order. When DataSerializers were
> added out of order to a client queue, some serializers would be lost.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java 09f9280f5ac26f034ce3456f0c490451bf82beb5
>
> Diff: https://reviews.apache.org/r/39523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 39523: GEODE-370: Using SerialDistributionMessage
for serializers
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39523/#review103471
-----------------------------------------------------------
It might be worthwhile to track down when this message was made a Pooled message instead of Serial.
The Instantiator code has a corresponding message and it is Serial already. It makes me wonder if we
had a bug long ago with DataSerializers jamming up the serial executor and it was fixed by changing this
to a Pooled message.
- Darrel Schneider
On Oct. 21, 2015, 1:41 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39523/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 1:41 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> DataSerializers were being sent using PooledDistributionMessage. That
> meant they could be processed out of order. When DataSerializers were
> added out of order to a client queue, some serializers would be lost.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java 09f9280f5ac26f034ce3456f0c490451bf82beb5
>
> Diff: https://reviews.apache.org/r/39523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>