You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2013/02/01 18:40:33 UTC
svn commit: r1441551 -
/spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm
Author: mmartinec
Date: Fri Feb 1 17:40:33 2013
New Revision: 1441551
URL: http://svn.apache.org/viewvc?rev=1441551&view=rev
Log:
partly revert previous debugging change, too much noise at the info level
Modified:
spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm
Modified: spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm?rev=1441551&r1=1441550&r2=1441551&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm Fri Feb 1 17:40:33 2013
@@ -754,18 +754,13 @@ sub poll_responses {
# NOERROR, may or may not have answer records
dbg("dns: dns response %s is OK, %d answer records",
$packet_id, $header->ancount);
- } elsif ($rcode eq 'NXDOMAIN') { # fairly common, no big deal
+ } else {
+ # some failure, e.g. NXDOMAIN, SERVFAIL, FORMERR, REFUSED, ...
+ # btw, one reason for SERVFAIL is an RR signature failure in DNSSEC
# NOTE: qname is encoded in RFC 1035 zone format, decode it
dbg("dns: dns response %s, %s, %s", $packet_id, $rcode,
join(', ', map(join('/', fmt_dns_question_entry($_)),
$packet->question)));
- } else {
- # some failure, e.g. SERVFAIL, FORMERR, REFUSED, ...
- # btw, one reason for SERVFAIL is an RR signature failure in DNSSEC
- # NOTE: qname is encoded in RFC 1035 zone format, decode it
- info("dns: dns response %s, %s, %s", $packet_id, $rcode,
- join(', ', map(join('/', fmt_dns_question_entry($_)),
- $packet->question)));
}
my $id = $self->_packet_id($packet);
my $cb = delete $self->{id_to_callback}->{$id};