You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/08 11:53:05 UTC
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
iamayushdas opened a new pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [x] Refactor
**What changes will this PR take into?**
Refactor Testcase for Frontend.
**Related issues**
related issue #1774
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835324353
Deploy preview for *apisix-dashboard* processing.
Building with commit f46f65ade0032ee4a0df17649f3e70ad966db6b1
https://app.netlify.com/sites/apisix-dashboard/deploys/609a7c9f32c3fa00076094ce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835333898
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1879](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f46f65a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **decrease** coverage by `3.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1879 +/- ##
==========================================
- Coverage 72.10% 68.91% -3.20%
==========================================
Files 125 122 -3
Lines 2947 3111 +164
Branches 711 745 +34
==========================================
+ Hits 2125 2144 +19
- Misses 822 967 +145
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.91% <ø> (-3.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `84.55% <0.00%> (-6.44%)` | :arrow_down: |
| [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <0.00%> (-1.72%)` | :arrow_down: |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <0.00%> (ø)` | |
| [.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz) | | |
| [...eb/src/components/PluginOrchestration/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29uc3RhbnRzLnRz) | | |
| [...components/PluginOrchestration/components/Page.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9QYWdlLnRzeA==) | | |
| [...eb/src/components/PluginOrchestration/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vdHJhbnNmb3JtLnRz) | | |
| [web/src/components/PluginOrchestration/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vaW5kZXgudHN4) | | |
| [web/src/components/PluginOrchestration/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vc2VydmljZS50cw==) | | |
| [...rc/components/PluginOrchestration/customConfig.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY3VzdG9tQ29uZmlnLnRzeA==) | | |
| ... and [10 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...f46f65a](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835333898
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1879](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (652bb99) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1879 +/- ##
==========================================
+ Coverage 72.10% 72.17% +0.06%
==========================================
Files 125 125
Lines 2947 2947
Branches 711 711
==========================================
+ Hits 2125 2127 +2
+ Misses 822 820 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `72.17% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...652bb99](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#discussion_r631165889
##########
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##########
@@ -17,117 +17,137 @@
/* eslint-disable no-undef */
context('Create and Delete Upstream', () => {
+
+ const selector = {
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "nodes_0_port": "#nodes_0_port",
+ "nodes_0_weight": "#nodes_0_weight",
+ "input": ":input",
+ "notification": ".ant-notification-notice-message",
+ "nameSelector": "[title=Name]",
+ "upstreamType": ".ant-select-item-option-content",
+ "drawer": ".ant-drawer-content",
+ "codemirrorScroll": ".CodeMirror-scroll",
+ "description": "#desc",
+ }
+
+ const data = {
+ "upstreamName": "test_upstream",
+ "description": "desc_by_autotest",
+ "ip1": "127.0.0.1",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ }
+
beforeEach(() => {
cy.login();
-
- cy.fixture('selector.json').as('domSelector');
- cy.fixture('data.json').as('data');
});
it('should create upstream with default type (roundrobin)', function () {
cy.visit('/');
cy.contains('Upstream').click();
cy.contains('Create').click();
- cy.get(this.domSelector.name).type(this.data.upstreamName);
- cy.get(this.domSelector.description).type(this.data.description);
+ cy.get(selector.name).type(data.upstreamName);
+ cy.get(selector.description).type(data.description);
- cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
- cy.get(this.domSelector.nodes_0_port).clear().type('7000');
- cy.get(this.domSelector.nodes_0_weight).clear().type(1);
+ cy.get(selector.nodes_0_host).type(data.ip1);
+ cy.get(selector.nodes_0_port).clear().type('7000');
Review comment:
Hi, 7000 is not required here, it can also be other values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#discussion_r629846359
##########
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##########
@@ -17,117 +17,137 @@
/* eslint-disable no-undef */
context('Create and Delete Upstream', () => {
+
+ const selector = {
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "nodes_0_port": "#nodes_0_port",
+ "nodes_0_weight": "#nodes_0_weight",
+ "input": ":input",
+ "notification": ".ant-notification-notice-message",
+ "nameSelector": "[title=Name]",
+ "upstreamType": ".ant-select-item-option-content",
+ "drawer": ".ant-drawer-content",
+ "codemirrorScroll": ".CodeMirror-scroll",
+ "description": "#desc",
+ }
+
+ const data = {
+ "upstreamName": "test_upstream",
+ "description": "desc_by_autotest",
+ "ip1": "127.0.0.1",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ }
+
beforeEach(() => {
cy.login();
-
- cy.fixture('selector.json').as('domSelector');
- cy.fixture('data.json').as('data');
});
it('should create upstream with default type (roundrobin)', function () {
cy.visit('/');
cy.contains('Upstream').click();
cy.contains('Create').click();
- cy.get(this.domSelector.name).type(this.data.upstreamName);
- cy.get(this.domSelector.description).type(this.data.description);
+ cy.get(selector.name).type(data.upstreamName);
+ cy.get(selector.description).type(data.description);
- cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
- cy.get(this.domSelector.nodes_0_port).clear().type('7000');
- cy.get(this.domSelector.nodes_0_weight).clear().type(1);
+ cy.get(selector.nodes_0_host).type(data.ip1);
+ cy.get(selector.nodes_0_port).clear().type('7000');
Review comment:
okay, sure...I defined it here because it was not re-occuring,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835324353
Deploy preview for *apisix-dashboard* ready!
Built with commit 652bb992933c124c31289b5771a77461e034b929
https://deploy-preview-1879--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#discussion_r629844775
##########
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##########
@@ -17,117 +17,137 @@
/* eslint-disable no-undef */
context('Create and Delete Upstream', () => {
+
+ const selector = {
+ "name": "#name",
+ "nodes_0_host": "#nodes_0_host",
+ "nodes_0_port": "#nodes_0_port",
+ "nodes_0_weight": "#nodes_0_weight",
+ "input": ":input",
+ "notification": ".ant-notification-notice-message",
+ "nameSelector": "[title=Name]",
+ "upstreamType": ".ant-select-item-option-content",
+ "drawer": ".ant-drawer-content",
+ "codemirrorScroll": ".CodeMirror-scroll",
+ "description": "#desc",
+ }
+
+ const data = {
+ "upstreamName": "test_upstream",
+ "description": "desc_by_autotest",
+ "ip1": "127.0.0.1",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ }
+
beforeEach(() => {
cy.login();
-
- cy.fixture('selector.json').as('domSelector');
- cy.fixture('data.json').as('data');
});
it('should create upstream with default type (roundrobin)', function () {
cy.visit('/');
cy.contains('Upstream').click();
cy.contains('Create').click();
- cy.get(this.domSelector.name).type(this.data.upstreamName);
- cy.get(this.domSelector.description).type(this.data.description);
+ cy.get(selector.name).type(data.upstreamName);
+ cy.get(selector.description).type(data.description);
- cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
- cy.get(this.domSelector.nodes_0_port).clear().type('7000');
- cy.get(this.domSelector.nodes_0_weight).clear().type(1);
+ cy.get(selector.nodes_0_host).type(data.ip1);
+ cy.get(selector.nodes_0_port).clear().type('7000');
Review comment:
it would be better to define test data for `7000` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835324353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835324353
Deploy preview for *apisix-dashboard* ready!
Built with commit f46f65ade0032ee4a0df17649f3e70ad966db6b1
https://deploy-preview-1879--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835324353
Deploy preview for *apisix-dashboard* processing.
Building with commit b935c38a1d06a41cd4ce6f2001b4e79cd0a73cb6
https://app.netlify.com/sites/apisix-dashboard/deploys/60967b9532dedb0007f7cf5b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#issuecomment-835333898
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1879](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b935c38) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head b935c38 differs from pull request most recent head 652bb99. Consider uploading reports for the commit 652bb99 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1879 +/- ##
==========================================
+ Coverage 72.10% 72.17% +0.06%
==========================================
Files 125 125
Lines 2947 2947
Branches 711 711
==========================================
+ Hits 2125 2127 +2
+ Misses 822 820 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `72.17% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1879/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...652bb99](https://codecov.io/gh/apache/apisix-dashboard/pull/1879?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org