[GitHub] [rocketmq-client-go] xujianhai666 commented on a change in pull request #102: [ISSUE #101] Add QueueSelector in producer

[GitBox <gi...@apache.org>]

xujianhai666 commented on a change in pull request #102: [ISSUE #101] Add QueueSelector in producer
URL: https://github.com/apache/rocketmq-client-go/pull/102#discussion_r301384992
 
 

 ##########
 File path: internal/producer/producer.go
 ##########
 @@ -276,9 +274,10 @@ func (p *defaultProducer) buildSendRequest(mq *primitive.MessageQueue,
 	return remote.NewRemotingCommand(kernel.ReqSendMessage, req, msg.Body)
 }
 
-func (p *defaultProducer) selectMessageQueue(topic string) *primitive.MessageQueue {
-	v, exist := p.publishInfo.Load(topic)
+func (p *defaultProducer) selectMessageQueue(msg *primitive.Message) *primitive.MessageQueue {
 
 Review comment:
   it seems that "msgs ...*primitive.Message" will not support in this version, we should discuss in next version. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services