You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Zheng Wang (Jira)" <ji...@apache.org> on 2020/08/19 06:51:00 UTC

[jira] [Updated] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

     [ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Wang updated HBASE-24898:
-------------------------------
    Description: In order to control the return value of getCurrentHour used by unit test.  (was: The valid number in OffPeakHours is 0-23, and the end hour not included, so we can not set all hours as offpeak hour now.

It is not useful for users in general, but useful for unit test, eg: TestStochasticLoadBalancer.testMoveCostMultiplier, in this case, the multiplier of move cost should be a lower value in offpeak, and we expect it always as offpeak hour no matter when it runs.

My proposal is just change the valid number from 0-23 to 0-24, then we can easily apply this pr to all active branchs, and folks do not need to change them configuration.)

> Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-24898
>                 URL: https://issues.apache.org/jira/browse/HBASE-24898
>             Project: HBase
>          Issue Type: Bug
>          Components: tooling
>            Reporter: Zheng Wang
>            Assignee: Zheng Wang
>            Priority: Major
>
> In order to control the return value of getCurrentHour used by unit test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)