You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/01/31 09:19:32 UTC
Review Request 56114: Log Search "Preview" should have a "Select for
Copy" button
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-19791
https://issues.apache.org/jira/browse/AMBARI-19791
Repository: ambari
Description
-------
In the log message context menu that contains the "Preview" feature, we need to add a "Select for Copy" button that will allow copying the log message to the clipboard
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js 57d4acd
Diff: https://reviews.apache.org/r/56114/diff/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
Re: Review Request 56114: Log Search "Preview" should have a "Select
for Copy" button
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/#review163659
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 31, 2017, 9:19 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56114/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:19 a.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19791
> https://issues.apache.org/jira/browse/AMBARI-19791
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the log message context menu that contains the "Preview" feature, we need to add a "Select for Copy" button that will allow copying the log message to the clipboard
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js 57d4acd
>
> Diff: https://reviews.apache.org/r/56114/diff/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56114: Log Search "Preview" should have a "Select
for Copy" button
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/#review163640
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Jan. 31, 2017, 9:19 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56114/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:19 a.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19791
> https://issues.apache.org/jira/browse/AMBARI-19791
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the log message context menu that contains the "Preview" feature, we need to add a "Select for Copy" button that will allow copying the log message to the clipboard
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js 57d4acd
>
> Diff: https://reviews.apache.org/r/56114/diff/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>