You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/28 22:33:51 UTC
[GitHub] [pinot] jackjlli commented on a diff in pull request #8980: adding MultiStageEngineQuickStart
jackjlli commented on code in PR #8980:
URL: https://github.com/apache/pinot/pull/8980#discussion_r909053634
##########
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java:
##########
@@ -218,11 +218,12 @@ private Map<String, Object> getDefaultConfig(ServiceRole serviceRole)
ControllerConf.ControllerMode.DUAL, true);
case BROKER:
return PinotConfigUtils
- .generateBrokerConf(_clusterName, _zkAddress, null, CommonConstants.Helix.DEFAULT_BROKER_QUERY_PORT);
+ .generateBrokerConf(_clusterName, _zkAddress, null, CommonConstants.Helix.DEFAULT_BROKER_QUERY_PORT, -1);
Review Comment:
Same here.
##########
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java:
##########
@@ -218,11 +218,12 @@ private Map<String, Object> getDefaultConfig(ServiceRole serviceRole)
ControllerConf.ControllerMode.DUAL, true);
case BROKER:
return PinotConfigUtils
- .generateBrokerConf(_clusterName, _zkAddress, null, CommonConstants.Helix.DEFAULT_BROKER_QUERY_PORT);
+ .generateBrokerConf(_clusterName, _zkAddress, null, CommonConstants.Helix.DEFAULT_BROKER_QUERY_PORT, -1);
case SERVER:
return PinotConfigUtils
.generateServerConf(_clusterName, _zkAddress, null, CommonConstants.Helix.DEFAULT_SERVER_NETTY_PORT,
- CommonConstants.Server.DEFAULT_ADMIN_API_PORT, CommonConstants.Server.DEFAULT_GRPC_PORT, null, null);
+ CommonConstants.Server.DEFAULT_ADMIN_API_PORT, CommonConstants.Server.DEFAULT_GRPC_PORT, -1, -1, null,
Review Comment:
Why not just use the default port value just as the other configs do, so that you don't have to validate whether the value is `<= 0`?
##########
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java:
##########
@@ -132,6 +136,7 @@ private void startBrokers()
for (int i = 0; i < _numBrokers; i++) {
StartBrokerCommand brokerStarter = new StartBrokerCommand();
brokerStarter.setPort(DEFAULT_BROKER_PORT + i)
+ .setBrokerMultiStageRunnerPort(DEFAULT_BROKER_MULTISTAGE_RUNNER_PORT - i)
Review Comment:
Can we use `+` instead of `-` since it's more intuitive? I know you did it because the `DEFAULT_SERVER_MULTISTAGE_RUNNER_PORT` is 8422. But can we update the value of `DEFAULT_SERVER_MULTISTAGE_RUNNER_PORT` to sth like 8442?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org