[GitHub] [airflow] ryanahamilton commented on a diff in pull request #22911: Update mapped task UX

[GitBox <gi...@apache.org>]

ryanahamilton commented on code in PR #22911:
URL: https://github.com/apache/airflow/pull/22911#discussion_r847565736


##########
airflow/www/templates/airflow/dag.html:
##########
@@ -272,14 +276,17 @@ <h4 class="modal-title" id="taskInstanceModalLabel">
             </div>
           {% endif %}
           <h4>Task Actions</h4>
-          <form method="POST" data-action="{{ url_for('Airflow.run') }}">
+          <form method="POST" data-action="{{ url_for('Airflow.run') }}" id="run_action">
             <input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
             <input type="hidden" name="dag_id" value="{{ dag.dag_id }}">
             <input type="hidden" name="task_id">
             <input type="hidden" name="dag_run_id">
             <input type="hidden" name="map_index">
             <input type="hidden" name="origin" value="{{ request.base_url }}">
             <div class="row">
+              <span class="col-xs-12 col-sm-9 text-danger" style="font-size: 12px">
+                {{ "Only works with the Celery, CeleryKubernetes or Kubernetes executors, sorry" if not k8s_or_k8scelery_executor else "" }}

Review Comment:
   Keep this consistent with the other instance in React
   ```suggestion
                   {{ "Only works with the Celery, CeleryKubernetes or Kubernetes executors" if not k8s_or_k8scelery_executor else "" }}
   ```



##########
airflow/www/static/js/tree/details/content/taskInstance/taskActions/Run.jsx:
##########
@@ -52,7 +58,7 @@ const Run = ({
 
   return (
     <Flex justifyContent="space-between" width="100%">
-      <ButtonGroup isAttached variant="outline">
+      <ButtonGroup isAttached variant="outline" disabled={!canRun}>

Review Comment:
   Is this visually different when disabled? I can't really tell from the the screenshot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org