You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/25 12:22:59 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
MartijnVisser opened a new pull request, #19815:
URL: https://github.com/apache/flink/pull/19815
## What is the purpose of the change
It's currently not possible to build the documentation when using the Hugo container (without having Hugo installed locally). This PR fixes that
## Brief change log
Bypass getting modules ourselves (which is needed to get documentation from the correct branch) and let the Hugo container handle this.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19815:
URL: https://github.com/apache/flink/pull/19815#issuecomment-1362787821
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #19815: [FLINK-27731][Documentation][Build] Remove Hugo Modules integration
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #19815:
URL: https://github.com/apache/flink/pull/19815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19815:
URL: https://github.com/apache/flink/pull/19815#issuecomment-1137245208
> Yeah, I'd be curious if we could come up with an alternative to that image, because it seems kinda eh.
We could decide to fork it and remove the hardwire + add bash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19815:
URL: https://github.com/apache/flink/pull/19815#issuecomment-1137302619
Do we want to maintain a second image that is capable of building the docs (beyond the CI image)? The CI image is a bit heavier than a purpose-built hugo image, but I'm not sure that is such a huge concern.
(at least for the time being; if we use a different image on CI for tasks where hugo is needed then that would be fine.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19815:
URL: https://github.com/apache/flink/pull/19815#issuecomment-1137218949
Ah I see, the hugo image is hard-wired to call hugo directly...and doesn't contain bash.
Yeah, I'd be curious if we could come up with an alternative to that image, because it seems kinda eh.
e.g.
`docker run -v $(pwd):/src -w /src -p 1313:1313 chesnay/flink-ci:java_8_11 ./build_docs.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19815:
URL: https://github.com/apache/flink/pull/19815#issuecomment-1137177267
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f9ca1f39cea5832a20a18e3c4a3d13626dbc896",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f9ca1f39cea5832a20a18e3c4a3d13626dbc896",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f9ca1f39cea5832a20a18e3c4a3d13626dbc896 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19815:
URL: https://github.com/apache/flink/pull/19815#issuecomment-1137205846
This change is weird. Shouldn't people run build_docs.sh in docker, which then also runs setup_docs.sh within the same container?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19815: [FLINK-27731][Documentation][Build] Make it possible to build documentation with Hugo container
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19815:
URL: https://github.com/apache/flink/pull/19815#issuecomment-1137204463
Am I understanding the issue correctly that the build fails because go is not installed in the hugo image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org