You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/11 22:53:49 UTC

[kudu-CR] linked list-test: set longer history retention 

Hello Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4374

to review the following change.

Change subject: linked_list-test: set longer history retention
......................................................................

linked_list-test: set longer history retention

The default 15 minute history retention was causing linked_list-test to
GC some history in the case that -seconds_to_run was set significantly
longer than the default.

This sets the retention to 1 day to prevent such issues.

I also removed an old unused function I noticed while making this
change.

Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
---
M src/kudu/integration-tests/linked_list-test.cc
1 file changed, 4 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/4374/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] linked list-test: set longer history retention

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: linked_list-test: set longer history retention
......................................................................


Patch Set 1: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/3356/

-- 
To view, visit http://gerrit.cloudera.org:8080/4374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] linked list-test: set longer history retention

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: linked_list-test: set longer history retention
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3355/

-- 
To view, visit http://gerrit.cloudera.org:8080/4374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] linked list-test: set longer history retention

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: linked_list-test: set longer history retention
......................................................................


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] linked list-test: set longer history retention

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.

Change subject: linked_list-test: set longer history retention
......................................................................


linked_list-test: set longer history retention

The default 15 minute history retention was causing linked_list-test to
GC some history in the case that -seconds_to_run was set significantly
longer than the default.

This sets the retention to 1 day to prevent such issues.

I also removed an old unused function I noticed while making this
change.

Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
Reviewed-on: http://gerrit.cloudera.org:8080/4374
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/linked_list-test.cc
1 file changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43395eb73c99f79be1884b6a22fab06f22c58980
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>