You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/16 02:22:04 UTC

[GitHub] [spark] uncleGen commented on a change in pull request #24609: [SPARK-27715][SQL] SQL query details in UI dose not show in correct format.

uncleGen commented on a change in pull request #24609: [SPARK-27715][SQL] SQL query details in UI dose not show in correct format.
URL: https://github.com/apache/spark/pull/24609#discussion_r284517901
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ##########
 @@ -388,7 +388,7 @@ private[ui] class ExecutionPagedTable(
         +details
       </span> ++
       <div class="stage-details collapsed">
-        <pre>{execution.description}<br></br>{execution.details}</pre>
+        <pre>{Unparsed(execution.description)}<br></br>{execution.details}</pre>
 
 Review comment:
   @srowen Sorry, I am not very familiar with XSS attack. But IMHO, it is a safe usage here and other places in Spark.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org