You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/10 14:49:58 UTC

[GitHub] [kafka] YeonCheolGit opened a new pull request #11663: calculate list size

YeonCheolGit opened a new pull request #11663:
URL: https://github.com/apache/kafka/pull/11663


   ### More detailed description of your change,
   _(This is my first PR for Kafka as junior engineer. This suggestion might be silly)_
   
   If `.size()` is called when it is needed, JVM has to calculate all the time. Maybe this is not good for performance.
   Hence what about assigning it one time and use many times? 
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] YeonCheolGit closed pull request #11663: assign only one time for size()

Posted by GitBox <gi...@apache.org>.
YeonCheolGit closed pull request #11663:
URL: https://github.com/apache/kafka/pull/11663


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org