You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/09/22 14:49:28 UTC

[GitHub] storm pull request #1707: STORM-2113 [Storm SQL] fix 'OR' and 'AND' operator...

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1707

    STORM-2113 [Storm SQL] fix 'OR' and 'AND' operators handle more than 2 operands

    NOTE: This is on top of STORM-2089 and STORM-2111 since this requires the ExprCompiler bugfix introduced on STORM-2111.
    
    After the patch 'IN' and 'NOT IN' operator works properly. It also respects 'short circuit'.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-2113

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1707.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1707
    
----
commit ce73a8b9fc4ee13620d07c1f621a36a7e327a872
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2016-09-13T02:40:13Z

    STORM-2089 Replace Consumer of ISqlTridentDataSource with SqlTridentConsumer
    
    * SqlTridentConsumer contains StateFactory and StateUpdater which is needed to store tuples to State via batch
    * Apply the change to storm-sql-kafka
    * move out JsonScheme and JsonSerializer to runtime
      * it will be used from other external sql modules
    * add javadoc to ISqlTridentDataSource

commit 3e050569e06276446e2bcec42dff80bfd659e8f4
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2016-09-22T06:38:44Z

    STORM-2111 [Storm SQL] support 'LIKE' and 'SIMILAR TO'
    
    * associate 'LIKE' and 'SIMILAR TO' to its implementation Calcite is providing
      * NOTE: SIMILAR TO takes SQL regex, not Java regex
    * add unit tests

commit ee32e8538f9e8dc765257318bd083da2a1a3ecb4
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2016-09-22T14:37:44Z

    STORM-2113 [Storm SQL] fix 'OR' and 'AND' operators handle more than 2 operands
    
    * This fix makes 'IN' and 'NOT IN' working properly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1707: STORM-2113 [Storm SQL] fix 'OR' and 'AND' operator...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR closed the pull request at:

    https://github.com/apache/storm/pull/1707


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1707: STORM-2113 [Storm SQL] fix 'OR' and 'AND' operators handl...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1707
  
    Closing this since STORM-2125 (#1714) covers this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---