You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "junrao (via GitHub)" <gi...@apache.org> on 2024/06/03 17:55:22 UTC

Re: [PR] KAFKA-16860; [1/2] Introduce group.version feature flag [kafka]

junrao commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1624848248


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -202,7 +202,10 @@ public enum MetadataVersion {
     IBP_3_7_IV4(19, "3.7", "IV4", false),
 
     // Add ELR related supports (KIP-966).
-    IBP_3_8_IV0(20, "3.8", "IV0", true);
+    IBP_3_8_IV0(20, "3.8", "IV0", true),
+
+    // Introduce version 1 of the GroupVersion feature (KIP-848).
+    IBP_4_0_IVO(21, "4.0", "IV0", false);

Review Comment:
   @dajac : It seems there is a typo. IBP_4_0_IVO should be IBP_4_0_IV0. The last zero was mis-typed as an O.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org