You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/06/06 02:11:09 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #7594: Fix: Volumes on lost local storage cannot be removed
nvazquez opened a new pull request, #7594:
URL: https://github.com/apache/cloudstack/pull/7594
### Description
This PR fixes the following:
- When destroying a local storage pool during host force deletion: then also destroy the volumes on the pool from DB
- When expunging a destroyed volume: check if the volume's storage pool exists (not removed). In case its removed, skip the volume removal from storage
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
- Create a local storage KVM zone
- Deploy a VM to local storage
- Force remove the host
- Delete the VM -> This succeeds but its volumes remain forever in "Destroy" (before the fix) -> After the fix: volumes are destroyed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1577827710
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1602169794
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1579117366
<b>[SF] Trillian test result (tid-6683)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46978 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7594-t6683-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1577836816
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#discussion_r1221650652
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1635,6 +1645,17 @@ private void expungeVolumesInPrimaryOrSecondary(VolumeVO volume, DataStoreRole r
}
}
}
+
+ private boolean canAccessVolumeStore(VolumeVO volume, DataStoreRole role) {
+ if (volume == null) {
+ throw new CloudRuntimeException("Cannot find the volume");
Review Comment:
Thanks @DaanHoogland, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1603382211
<b>[SF] Trillian test result (tid-6811)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50678 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7594-t6811-kvm-centos7.zip
Smoke tests completed. 104 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 78.71 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 52.38 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 225.86 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 140.91 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 150.16 | test_vm_life_cycle.py
test_01_verify_ipv6_vpc | `Error` | 601.41 | test_vpc_ipv6.py
test_02_redundant_VPC_default_routes | `Failure` | 632.33 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 497.28 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 497.30 | test_vpc_redundant.py
test_02_VPC_default_routes | `Failure` | 172.52 | test_vpc_router_nics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1602170172
@kiranchavala a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1577846843
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7594?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7594](https://app.codecov.io/gh/apache/cloudstack/pull/7594?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d0c1f0d) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/b2e9993b0acf94d57113837951401170d692eaff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b2e9993) will **increase** coverage by `0.00%`.
> The diff coverage is `48.83%`.
```diff
@@ Coverage Diff @@
## 4.18 #7594 +/- ##
=========================================
Coverage 12.97% 12.98%
- Complexity 8978 8990 +12
=========================================
Files 2716 2716
Lines 256309 256352 +43
Branches 39968 39977 +9
=========================================
+ Hits 33268 33286 +18
- Misses 218880 218901 +21
- Partials 4161 4165 +4
```
| [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/com/cloud/storage/dao/VolumeDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL2Rhby9Wb2x1bWVEYW9JbXBsLmphdmE=) | `23.23% <0.00%> (-0.39%)` | :arrow_down: |
| [...n/java/com/cloud/resource/ResourceManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3Jlc291cmNlL1Jlc291cmNlTWFuYWdlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ain/java/com/cloud/storage/StorageManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvU3RvcmFnZU1hbmFnZXJJbXBsLmphdmE=) | `1.59% <65.00%> (+0.70%)` | :arrow_up: |
| [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `15.30% <80.00%> (+0.27%)` | :arrow_up: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7594/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1599056583
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1581077299
@nvazquez a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#discussion_r1223932572
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -979,6 +983,7 @@ public void doInTransactionWithoutResult(final TransactionStatus status) {
final Long poolId = pool.getPoolId();
final StoragePoolVO storagePool = _storagePoolDao.findById(poolId);
if (storagePool.isLocal() && isForceDeleteStorage) {
+ destroyLocalStoragePoolVolumes(poolId);
Review Comment:
this should be good :+1:
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1635,6 +1645,17 @@ private void expungeVolumesInPrimaryOrSecondary(VolumeVO volume, DataStoreRole r
}
}
}
+
+ private boolean canAccessVolumeStore(VolumeVO volume, DataStoreRole role) {
+ if (volume == null) {
+ throw new CloudRuntimeException("No volume given, cannot check access to volume store");
+ }
+ InternalIdentity pool = role == DataStoreRole.Primary ?
+ _storagePoolDao.findById(volume.getPoolId()) :
+ imageStoreDao.findById(volume.getPoolId());
Review Comment:
use switch/case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1577839011
@nvazquez a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1599150146
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1581073913
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1581037915
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1599059045
@nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1599056254
Thanks @kiranchavala, have pushed a fix for that scenario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1577787738
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1580885322
@nvazquez a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1580883006
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1581891826
<b>[SF] Trillian test result (tid-6703)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46712 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7594-t6703-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_list_vms_metrics_admin | `Error` | 3608.74 | test_metrics_api.py
test_list_vms_metrics_history | `Error` | 7.42 | test_metrics_api.py
test_list_volumes_metrics_history | `Error` | 7.38 | test_metrics_api.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#discussion_r1219526397
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1635,6 +1645,17 @@ private void expungeVolumesInPrimaryOrSecondary(VolumeVO volume, DataStoreRole r
}
}
}
+
+ private boolean canAccessVolumeStore(VolumeVO volume, DataStoreRole role) {
+ if (volume == null) {
+ throw new CloudRuntimeException("Cannot find the volume");
Review Comment:
this is a strange message in this place. We are not trying to find it here, but we claim that is what failed. maybe this check should be somewhere else or the message should be adjusted to "No Volume given" or so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594#issuecomment-1577789267
@nvazquez a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7594: Fix: Volumes on lost local storage cannot be removed
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7594:
URL: https://github.com/apache/cloudstack/pull/7594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org