You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/12/03 09:21:27 UTC
Review Request 40899: LENS-851: Replace columns with aliases in where
clause of the inner query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
Diff: https://reviews.apache.org/r/40899/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 10, 2015, 8:14 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line 152
> > <https://reviews.apache.org/r/40899/diff/4/?file=1158242#file1158242line152>
> >
> > Can it throw LensException out instead of catching and throwing IllegalArgumentException?
>
> Rajat Khandelwal wrote:
> * There will be signature changes for other functions.
> * this function is used in `hashCode()`. There we can't throw so will have to add try-catch there. Converting to RTE is okay I guess.
The error wont get propagated to client with RTE. Can we do that only in hashCode() ?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109705
-----------------------------------------------------------
On Dec. 10, 2015, 9:05 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:05 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 10, 2015, 1:44 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line 152
> > <https://reviews.apache.org/r/40899/diff/4/?file=1158242#file1158242line152>
> >
> > Can it throw LensException out instead of catching and throwing IllegalArgumentException?
* There will be signature changes for other functions.
* this function is used in `hashCode()`. There we can't throw so will have to add try-catch there. Converting to RTE is okay I guess.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109705
-----------------------------------------------------------
On Dec. 10, 2015, 2:35 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 2:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109705
-----------------------------------------------------------
lens-api/src/main/resources/lens-errors.conf (lines 294 - 295)
<https://reviews.apache.org/r/40899/#comment169317>
Should be INTERNAL_SERVER_ERROR here.
lens-api/src/main/resources/lens-errors.conf (line 314)
<https://reviews.apache.org/r/40899/#comment169318>
Should be BAD_REQUEST here
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java (line 151)
<https://reviews.apache.org/r/40899/#comment169319>
Can it throw LensException out instead of catching and throwing IllegalArgumentException?
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java (line 22)
<https://reviews.apache.org/r/40899/#comment169321>
Should be using error code > 3100
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java (line 179)
<https://reviews.apache.org/r/40899/#comment169322>
Should be changed to new error code.
- Amareshwari Sriramadasu
On Dec. 10, 2015, 7:46 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 7:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 10, 2015, 12:28 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java, lines 57-58
> > <https://reviews.apache.org/r/40899/diff/6/?file=1158481#file1158481line57>
> >
> > I think weights of these error codes should be more than 1400. can you change?
Can you increase weight of STORAGE_UNION_DISABLED also?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109746
-----------------------------------------------------------
On Dec. 11, 2015, 7:35 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 7:35 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 8770f1a76572cca36978df6ecb077b425d140c34
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java a5883f7b852f1d2a104d46e234546508422be172
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.873s]
> [INFO] Lens .............................................. SUCCESS [2.927s]
> [INFO] Lens API .......................................... SUCCESS [24.639s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.716s]
> [INFO] Lens Cube ......................................... SUCCESS [12:18.390s]
> [INFO] Lens DB storage ................................... SUCCESS [24.670s]
> [INFO] Lens Query Library ................................ SUCCESS [19.728s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:10.599s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.097s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.525s]
> [INFO] Lens Server ....................................... SUCCESS [9:47.931s]
> [INFO] Lens client ....................................... SUCCESS [37.521s]
> [INFO] Lens CLI .......................................... SUCCESS [55.112s]
> [INFO] Lens Examples ..................................... SUCCESS [10.632s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [9.045s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.648s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.935s]
> [INFO] Lens Regression ................................... SUCCESS [14.437s]
> [INFO] Lens UI ........................................... SUCCESS [28.745s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:49.869s
> [INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
> [INFO] Final Memory: 204M/2104M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109746
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java (lines 57 - 58)
<https://reviews.apache.org/r/40899/#comment169369>
I think weights of these error codes should be more than 1400. can you change?
- Amareshwari Sriramadasu
On Dec. 10, 2015, 11:31 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 11:31 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 8770f1a76572cca36978df6ecb077b425d140c34
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java a5883f7b852f1d2a104d46e234546508422be172
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.873s]
> [INFO] Lens .............................................. SUCCESS [2.927s]
> [INFO] Lens API .......................................... SUCCESS [24.639s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.716s]
> [INFO] Lens Cube ......................................... SUCCESS [12:18.390s]
> [INFO] Lens DB storage ................................... SUCCESS [24.670s]
> [INFO] Lens Query Library ................................ SUCCESS [19.728s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:10.599s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.097s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.525s]
> [INFO] Lens Server ....................................... SUCCESS [9:47.931s]
> [INFO] Lens client ....................................... SUCCESS [37.521s]
> [INFO] Lens CLI .......................................... SUCCESS [55.112s]
> [INFO] Lens Examples ..................................... SUCCESS [10.632s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [9.045s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.648s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.935s]
> [INFO] Lens Regression ................................... SUCCESS [14.437s]
> [INFO] Lens UI ........................................... SUCCESS [28.745s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:49.869s
> [INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
> [INFO] Final Memory: 204M/2104M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109947
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Dec. 11, 2015, 11:04 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 11:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 8770f1a76572cca36978df6ecb077b425d140c34
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java a5883f7b852f1d2a104d46e234546508422be172
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.873s]
> [INFO] Lens .............................................. SUCCESS [2.927s]
> [INFO] Lens API .......................................... SUCCESS [24.639s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.716s]
> [INFO] Lens Cube ......................................... SUCCESS [12:18.390s]
> [INFO] Lens DB storage ................................... SUCCESS [24.670s]
> [INFO] Lens Query Library ................................ SUCCESS [19.728s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:10.599s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.097s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.525s]
> [INFO] Lens Server ....................................... SUCCESS [9:47.931s]
> [INFO] Lens client ....................................... SUCCESS [37.521s]
> [INFO] Lens CLI .......................................... SUCCESS [55.112s]
> [INFO] Lens Examples ..................................... SUCCESS [10.632s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
> [INFO] Lens Distribution ................................. SUCCESS [9.045s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.648s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.935s]
> [INFO] Lens Regression ................................... SUCCESS [14.437s]
> [INFO] Lens UI ........................................... SUCCESS [28.745s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:49.869s
> [INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
> [INFO] Final Memory: 204M/2104M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 4:34 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 8770f1a76572cca36978df6ecb077b425d140c34
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java a5883f7b852f1d2a104d46e234546508422be172
Diff: https://reviews.apache.org/r/40899/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.873s]
[INFO] Lens .............................................. SUCCESS [2.927s]
[INFO] Lens API .......................................... SUCCESS [24.639s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.716s]
[INFO] Lens Cube ......................................... SUCCESS [12:18.390s]
[INFO] Lens DB storage ................................... SUCCESS [24.670s]
[INFO] Lens Query Library ................................ SUCCESS [19.728s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:10.599s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.097s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.525s]
[INFO] Lens Server ....................................... SUCCESS [9:47.931s]
[INFO] Lens client ....................................... SUCCESS [37.521s]
[INFO] Lens CLI .......................................... SUCCESS [55.112s]
[INFO] Lens Examples ..................................... SUCCESS [10.632s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
[INFO] Lens Distribution ................................. SUCCESS [9.045s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.648s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.935s]
[INFO] Lens Regression ................................... SUCCESS [14.437s]
[INFO] Lens UI ........................................... SUCCESS [28.745s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:49.869s
[INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
[INFO] Final Memory: 204M/2104M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 1:05 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 8770f1a76572cca36978df6ecb077b425d140c34
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java a5883f7b852f1d2a104d46e234546508422be172
Diff: https://reviews.apache.org/r/40899/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.873s]
[INFO] Lens .............................................. SUCCESS [2.927s]
[INFO] Lens API .......................................... SUCCESS [24.639s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.716s]
[INFO] Lens Cube ......................................... SUCCESS [12:18.390s]
[INFO] Lens DB storage ................................... SUCCESS [24.670s]
[INFO] Lens Query Library ................................ SUCCESS [19.728s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:10.599s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.097s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.525s]
[INFO] Lens Server ....................................... SUCCESS [9:47.931s]
[INFO] Lens client ....................................... SUCCESS [37.521s]
[INFO] Lens CLI .......................................... SUCCESS [55.112s]
[INFO] Lens Examples ..................................... SUCCESS [10.632s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
[INFO] Lens Distribution ................................. SUCCESS [9.045s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.648s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.935s]
[INFO] Lens Regression ................................... SUCCESS [14.437s]
[INFO] Lens UI ........................................... SUCCESS [28.745s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:49.869s
[INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
[INFO] Final Memory: 204M/2104M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 5:01 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 8770f1a76572cca36978df6ecb077b425d140c34
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java a5883f7b852f1d2a104d46e234546508422be172
Diff: https://reviews.apache.org/r/40899/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.873s]
[INFO] Lens .............................................. SUCCESS [2.927s]
[INFO] Lens API .......................................... SUCCESS [24.639s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.716s]
[INFO] Lens Cube ......................................... SUCCESS [12:18.390s]
[INFO] Lens DB storage ................................... SUCCESS [24.670s]
[INFO] Lens Query Library ................................ SUCCESS [19.728s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:10.599s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.097s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.525s]
[INFO] Lens Server ....................................... SUCCESS [9:47.931s]
[INFO] Lens client ....................................... SUCCESS [37.521s]
[INFO] Lens CLI .......................................... SUCCESS [55.112s]
[INFO] Lens Examples ..................................... SUCCESS [10.632s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s]
[INFO] Lens Distribution ................................. SUCCESS [9.045s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.648s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.935s]
[INFO] Lens Regression ................................... SUCCESS [14.437s]
[INFO] Lens UI ........................................... SUCCESS [28.745s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:49.869s
[INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
[INFO] Final Memory: 204M/2104M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 2:35 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
Diff: https://reviews.apache.org/r/40899/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
[INFO] Lens .............................................. SUCCESS [1.371s]
[INFO] Lens API .......................................... SUCCESS [7.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
[INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
[INFO] Lens DB storage ................................... SUCCESS [11.174s]
[INFO] Lens Query Library ................................ SUCCESS [5.068s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
[INFO] Lens Server ....................................... SUCCESS [10:04.272s]
[INFO] Lens client ....................................... SUCCESS [23.400s]
[INFO] Lens CLI .......................................... SUCCESS [40.574s]
[INFO] Lens Examples ..................................... SUCCESS [0.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
[INFO] Lens Distribution ................................. SUCCESS [8.315s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
[INFO] Lens Regression ................................... SUCCESS [2.549s]
[INFO] Lens UI ........................................... SUCCESS [26.262s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:52.090s
[INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
[INFO] Final Memory: 170M/922M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 1:16 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf ca8562f14fe9f45889ea59b055cdd1b001f02810
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4ec049c103bdae662fc7f869aa32199e768a4b64
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e5dbde7af58f74db4ae2a86d9eda602def25d9fe
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
Diff: https://reviews.apache.org/r/40899/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
[INFO] Lens .............................................. SUCCESS [1.371s]
[INFO] Lens API .......................................... SUCCESS [7.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
[INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
[INFO] Lens DB storage ................................... SUCCESS [11.174s]
[INFO] Lens Query Library ................................ SUCCESS [5.068s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
[INFO] Lens Server ....................................... SUCCESS [10:04.272s]
[INFO] Lens client ....................................... SUCCESS [23.400s]
[INFO] Lens CLI .......................................... SUCCESS [40.574s]
[INFO] Lens Examples ..................................... SUCCESS [0.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
[INFO] Lens Distribution ................................. SUCCESS [8.315s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
[INFO] Lens Regression ................................... SUCCESS [2.549s]
[INFO] Lens UI ........................................... SUCCESS [26.262s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:52.090s
[INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
[INFO] Final Memory: 170M/922M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 5:09 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
Diff: https://reviews.apache.org/r/40899/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
[INFO] Lens .............................................. SUCCESS [1.371s]
[INFO] Lens API .......................................... SUCCESS [7.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
[INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
[INFO] Lens DB storage ................................... SUCCESS [11.174s]
[INFO] Lens Query Library ................................ SUCCESS [5.068s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
[INFO] Lens Server ....................................... SUCCESS [10:04.272s]
[INFO] Lens client ....................................... SUCCESS [23.400s]
[INFO] Lens CLI .......................................... SUCCESS [40.574s]
[INFO] Lens Examples ..................................... SUCCESS [0.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
[INFO] Lens Distribution ................................. SUCCESS [8.315s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
[INFO] Lens Regression ................................... SUCCESS [2.549s]
[INFO] Lens UI ........................................... SUCCESS [26.262s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:52.090s
[INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
[INFO] Final Memory: 170M/922M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 4, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179>
> >
> > I think we already have error code for parsing, can we use that here?
We're using SYNTAX_ERROR in other places, used that here too :)
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
-----------------------------------------------------------
On Dec. 3, 2015, 3:18 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 3:18 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179>
> >
> > I think we already have error code for parsing, can we use that here?
>
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)
>
> Amareshwari Sriramadasu wrote:
> SYNTAX_ERROR is for query, and expression parsing is for metastore. Please confirm if my statement is correct.
> Shall we create a metastore error code (>3100) and pass it from parseExpr ?
>
> Rajat Khandelwal wrote:
> parseExpr is used in both `cube.metadata` and `cube.parse` modules. wrong expressions can also occur while processing a query.
>
> Amareshwari Sriramadasu wrote:
> I'm inclined to creating an expression parsing error code instead of syntax error - mainly because hitting expression parsing error during query writing might be unlikely because entity creation itself would fail with that error. The current code throwing exception during query writing would never be hit - if entity creation has failed.
>
> Rajat Khandelwal wrote:
> Yes, if in query writing expression parsing gives an error then it's a programming error (RuntimeException). Shall I create another code and use here?
Let us separate parseExpr into two different methods - MetastoreUtil throwing metastore error code (maps to 400) and HQLParser throwing parse error code (maps to 500).
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
-----------------------------------------------------------
On Dec. 4, 2015, 11:39 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 11:39 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 4, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179>
> >
> > I think we already have error code for parsing, can we use that here?
>
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)
>
> Amareshwari Sriramadasu wrote:
> SYNTAX_ERROR is for query, and expression parsing is for metastore. Please confirm if my statement is correct.
> Shall we create a metastore error code (>3100) and pass it from parseExpr ?
parseExpr is used in both `cube.metadata` and `cube.parse` modules. wrong expressions can also occur while processing a query.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
-----------------------------------------------------------
On Dec. 4, 2015, 5:09 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 5:09 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179>
> >
> > I think we already have error code for parsing, can we use that here?
>
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)
SYNTAX_ERROR is for query, and expression parsing is for metastore. Please confirm if my statement is correct.
Shall we create a metastore error code (>3100) and pass it from parseExpr ?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
-----------------------------------------------------------
On Dec. 4, 2015, 11:39 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 11:39 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 4, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179>
> >
> > I think we already have error code for parsing, can we use that here?
>
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)
>
> Amareshwari Sriramadasu wrote:
> SYNTAX_ERROR is for query, and expression parsing is for metastore. Please confirm if my statement is correct.
> Shall we create a metastore error code (>3100) and pass it from parseExpr ?
>
> Rajat Khandelwal wrote:
> parseExpr is used in both `cube.metadata` and `cube.parse` modules. wrong expressions can also occur while processing a query.
>
> Amareshwari Sriramadasu wrote:
> I'm inclined to creating an expression parsing error code instead of syntax error - mainly because hitting expression parsing error during query writing might be unlikely because entity creation itself would fail with that error. The current code throwing exception during query writing would never be hit - if entity creation has failed.
Yes, if in query writing expression parsing gives an error then it's a programming error (RuntimeException). Shall I create another code and use here?
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
-----------------------------------------------------------
On Dec. 4, 2015, 5:09 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 5:09 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179>
> >
> > I think we already have error code for parsing, can we use that here?
>
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)
>
> Amareshwari Sriramadasu wrote:
> SYNTAX_ERROR is for query, and expression parsing is for metastore. Please confirm if my statement is correct.
> Shall we create a metastore error code (>3100) and pass it from parseExpr ?
>
> Rajat Khandelwal wrote:
> parseExpr is used in both `cube.metadata` and `cube.parse` modules. wrong expressions can also occur while processing a query.
I'm inclined to creating an expression parsing error code instead of syntax error - mainly because hitting expression parsing error during query writing might be unlikely because entity creation itself would fail with that error. The current code throwing exception during query writing would never be hit - if entity creation has failed.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
-----------------------------------------------------------
On Dec. 4, 2015, 11:39 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 11:39 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java (line 179)
<https://reviews.apache.org/r/40899/#comment168370>
I think we already have error code for parsing, can we use that here?
- Amareshwari Sriramadasu
On Dec. 3, 2015, 9:48 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 9:48 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
> lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
>
> Diff: https://reviews.apache.org/r/40899/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
> [INFO] Lens .............................................. SUCCESS [1.371s]
> [INFO] Lens API .......................................... SUCCESS [7.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
> [INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
> [INFO] Lens DB storage ................................... SUCCESS [11.174s]
> [INFO] Lens Query Library ................................ SUCCESS [5.068s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
> [INFO] Lens Server ....................................... SUCCESS [10:04.272s]
> [INFO] Lens client ....................................... SUCCESS [23.400s]
> [INFO] Lens CLI .......................................... SUCCESS [40.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
> [INFO] Lens Distribution ................................. SUCCESS [8.315s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
> [INFO] Lens Regression ................................... SUCCESS [2.549s]
> [INFO] Lens UI ........................................... SUCCESS [26.262s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40899: LENS-851: Replace columns with aliases in
where clause of the inner query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
-----------------------------------------------------------
(Updated Dec. 3, 2015, 3:18 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8
Diff: https://reviews.apache.org/r/40899/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s]
[INFO] Lens .............................................. SUCCESS [1.371s]
[INFO] Lens API .......................................... SUCCESS [7.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [9.282s]
[INFO] Lens Cube ......................................... SUCCESS [5:14.939s]
[INFO] Lens DB storage ................................... SUCCESS [11.174s]
[INFO] Lens Query Library ................................ SUCCESS [5.068s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s]
[INFO] Lens Server ....................................... SUCCESS [10:04.272s]
[INFO] Lens client ....................................... SUCCESS [23.400s]
[INFO] Lens CLI .......................................... SUCCESS [40.574s]
[INFO] Lens Examples ..................................... SUCCESS [0.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s]
[INFO] Lens Distribution ................................. SUCCESS [8.315s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s]
[INFO] Lens Regression ................................... SUCCESS [2.549s]
[INFO] Lens UI ........................................... SUCCESS [26.262s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:52.090s
[INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
[INFO] Final Memory: 170M/922M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal