You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:51:24 UTC

[GitHub] [maven-fluido-skin] dialaya opened a new pull request #18: [MSKINS-168] Switch Minification Engine from YUI to CLOSURE

dialaya opened a new pull request #18:
URL: https://github.com/apache/maven-fluido-skin/pull/18


   YUI compressor engine seems not support ES5 syntaxes.
   Js compilation fails when using new javascript libraries with ES5 syntax.
   
   Switch to CLOSURE engine to bypass the issues.
   
   Closes #168


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-fluido-skin] hboutemy commented on pull request #18: [MSKINS-168] Switch Minification Engine from YUI to CLOSURE

Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #18:
URL: https://github.com/apache/maven-fluido-skin/pull/18#issuecomment-634897602


   nice change, well explained: thank you @dialaya 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-fluido-skin] michael-o commented on pull request #18: [MSKINS-168] Switch Minification Engine from YUI to CLOSURE

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #18:
URL: https://github.com/apache/maven-fluido-skin/pull/18#issuecomment-634261843






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-fluido-skin] dialaya edited a comment on pull request #18: [MSKINS-168] Switch Minification Engine from YUI to CLOSURE

Posted by GitBox <gi...@apache.org>.
dialaya edited a comment on pull request #18:
URL: https://github.com/apache/maven-fluido-skin/pull/18#issuecomment-634326282


   below target JS libs are affected: 
   + anchorjs
   + bootstrap 4
   + jquery 3
   + or any other new lib that uses ES5 or greater you might need to use later
   
   Without the switch: i made changes in anchorjs lib that you can see in my previous pull request #17 that I had aborted to avoid custom maintenance.
   
   But for jquery and bootstrap I is not a good idea to modify the syntax because of ES5 support issues.
   
   Please see [MSKINS-168](https://issues.apache.org/jira/browse/MSKINS-168) for more details.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-fluido-skin] hboutemy merged pull request #18: [MSKINS-168] Switch Minification Engine from YUI to CLOSURE

Posted by GitBox <gi...@apache.org>.
hboutemy merged pull request #18:
URL: https://github.com/apache/maven-fluido-skin/pull/18


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-fluido-skin] dialaya commented on pull request #18: [MSKINS-168] Switch Minification Engine from YUI to CLOSURE

Posted by GitBox <gi...@apache.org>.
dialaya commented on pull request #18:
URL: https://github.com/apache/maven-fluido-skin/pull/18#issuecomment-634253705






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-fluido-skin] dialaya commented on pull request #18: [MSKINS-168] Switch Minification Engine from YUI to CLOSURE

Posted by GitBox <gi...@apache.org>.
dialaya commented on pull request #18:
URL: https://github.com/apache/maven-fluido-skin/pull/18#issuecomment-635667933


   Thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org