[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #3541: Fixes #3370 #3539 and #2949 .Fix and change some code structure

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #3541: Fixes #3370 #3539 and #2949 .Fix and change some code structure
URL: https://github.com/apache/incubator-shardingsphere/pull/3541#discussion_r347194657
 
 

 ##########
 File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/MariaDBDataSourceMetaData.java
 ##########
 @@ -41,6 +44,8 @@
 
     private final String schemaName;
 
+    private final String catalog;
+
     private final Pattern pattern = Pattern.compile("jdbc:(mysql|mariadb)(:replication|:failover|:sequential|:aurora)?:(\\w*:)?//([\\w\\-\\.]+):?([0-9]*)/([\\w\\-]+);?\\S*", Pattern.CASE_INSENSITIVE);
 
     public MariaDBDataSourceMetaData(final String url) {
 
 Review comment:
   I think it is not necessary after `MariaDBDataSourceMetaData(final DataSourceInfo dataSourceInfo)` is added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services