You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Justin Mclean <ju...@classsoftware.com> on 2018/05/11 04:05:32 UTC
Dubbo release candidate
Hi,
I saw that a release candidate has been put up here [1] and I had a quick look at it. It looks good to me with a couple of minor issues:
- The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not required) Not this will make the connivance binary LICENSE file different to the source LICENSE file
- The binary jars in libs are missing LICENSE and NOTICE files in META-INF
You may want to fix these before calling a vote but I think this sees could be fixed in the next release if you prefer that. Other mentors/PMC member may have a different opinion to me.
Thanks,
Justin
1. https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
Re: Dubbo release candidate
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Just a quick question, should the LICENSE and NOTICE file in META-INF
> only contain information in this specific jar, or should contain
> information of the entire binary?
I’d go with what is in the jar as per [1] (as I jar could be pulled out and used on it’s own) but it’s not a big deal for the first release. Having them al the same IMO as having a little too much is a documentation issue not a licensing issue.
Thanks,
Justin
1. http://www.apache.org/dev/licensing-howto.html#guiding-principle
Re: Dubbo release candidate
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Fri, May 11, 2018 at 12:05 PM, Justin Mclean
<ju...@classsoftware.com> wrote:
> Hi,
>
> I saw that a release candidate has been put up here [1] and I had a quick look at it. It looks good to me with a couple of minor issues:
> - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not required) Not this will make the connivance binary LICENSE file different to the source LICENSE file
> - The binary jars in libs are missing LICENSE and NOTICE files in META-INF
Just a quick question, should the LICENSE and NOTICE file in META-INF
only contain information in this specific jar, or should contain
information of the entire binary?
>
> You may want to fix these before calling a vote but I think this sees could be fixed in the next release if you prefer that. Other mentors/PMC member may have a different opinion to me.
If this is not something cost us too much work, I think we can fix it.
>
> Thanks,
> Justin
>
> 1. https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
--
Best Regards！
Huxing
Re: Dubbo release candidate
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Fri, May 11, 2018 at 2:35 PM, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
>> hessian-lite-3.2.2.jar is a part of this release, both resource and binary should include hessian-lite. So now we need add clarification of hessian-lite in the LICENSE and NOTICE files in libs, right?
>
> It’s ALv2 and from what I can see there no notice file. Is that correct? If so it could be added to LICENSE but it’s not required and no changes are needed for NOTICE.
Yes, hessian-lite is already in LICENSE and no extra NOTICE info is needed.
>
> Thanks,
> Justin
--
Best Regards！
Huxing
Re: Dubbo release candidate
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> hessian-lite-3.2.2.jar is a part of this release, both resource and binary should include hessian-lite. So now we need add clarification of hessian-lite in the LICENSE and NOTICE files in libs, right?
It’s ALv2 and from what I can see there no notice file. Is that correct? If so it could be added to LICENSE but it’s not required and no changes are needed for NOTICE.
Thanks,
Justin
Re: Dubbo release candidate
Posted by jun liu <ke...@gmail.com>.
> What about hessian-lite-3.2.2.jar should that be there?
hessian-lite-3.2.2.jar is a part of this release, both resource and binary should include hessian-lite. So now we need add clarification of hessian-lite in the LICENSE and NOTICE files in libs, right?
FYI, hessian-lite a customized version of the official hessian maintained inside dubbo now, we are considering of moving hessian-ilte from the core project to eco-system, we can discuss this further in another thread.
> On 11 May 2018, at 1:45 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
>>> - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not required) Not this will make the connivance binary LICENSE file different to the source LICENSE file
>>
>> FastJSON should not be part of the binary release, should be caused by a bug of filters, i will remove it.
>
> Which is another way of fixing it and you don’t need to change the LICENSE or NOTICE.
>
> What about hessian-lite-3.2.2.jar should that be there?
>
> Thanks,
> Justin
Re: Dubbo release candidate
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
>> - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not required) Not this will make the connivance binary LICENSE file different to the source LICENSE file
>
> FastJSON should not be part of the binary release, should be caused by a bug of filters, i will remove it.
Which is another way of fixing it and you don’t need to change the LICENSE or NOTICE.
What about hessian-lite-3.2.2.jar should that be there?
Thanks,
Justin
Re: Dubbo release candidate
Posted by jun liu <ke...@gmail.com>.
> - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not required) Not this will make the connivance binary LICENSE file different to the source LICENSE file
FastJSON should not be part of the binary release, should be caused by a bug of filters, i will remove it.
> - The binary jars in libs are missing LICENSE and NOTICE files in META-INF
We prefer to use the same LICENSE and NOTICE files in libs to fill the missing part of each binary jar,
Best regards,
Jun
> On 11 May 2018, at 12:05 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> I saw that a release candidate has been put up here [1] and I had a quick look at it. It looks good to me with a couple of minor issues:
> - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not required) Not this will make the connivance binary LICENSE file different to the source LICENSE file
> - The binary jars in libs are missing LICENSE and NOTICE files in META-INF
>
> You may want to fix these before calling a vote but I think this sees could be fixed in the next release if you prefer that. Other mentors/PMC member may have a different opinion to me.
>
> Thanks,
> Justin
>
> 1. https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/