You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by manugarri <gi...@git.apache.org> on 2017/02/07 16:52:32 UTC
[GitHub] spark pull request #16836: remove parenthesis in readStream() on kafka struc...
GitHub user manugarri opened a pull request:
https://github.com/apache/spark/pull/16836
remove parenthesis in readStream() on kafka structured streaming doc
## What changes were proposed in this pull request?
There is a typo in http://spark.apache.org/docs/latest/structured-streaming-kafka-integration.html#creating-a-kafka-source-stream , python example n1 uses `readStream()` instead of `readStream`
## How was this patch tested?
Just removed the parenthesis.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manugarri/spark fix_kafka_python_doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16836
----
commit ea313ae236d8ace7a553434093aea9d6bea2b0b6
Author: manugarri <ma...@gmail.com>
Date: 2017-02-07T16:50:43Z
remove parenthesis in readStream() on kafka structured streaming doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16836: remove parenthesis in readStream() on kafka struc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16836
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16836: remove parenthesis in readStream() on kafka structured s...
Posted by manugarri <gi...@git.apache.org>.
Github user manugarri commented on the issue:
https://github.com/apache/spark/pull/16836
@srowen it does not work. And you were right, I removed the other parenthesis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16836: remove parenthesis in readStream() on kafka structured s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16836
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16836: remove parenthesis in readStream() on kafka structured s...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/16836
Aah, since readStream in python is marked as property, @manugarri may be right about it not working. I remember that i did not verify the code by running them. @zsxwing did you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16836: remove parenthesis in readStream() on kafka structured s...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16836
LGTM. Merging to master and 2.1 since this only touches docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16836: remove parenthesis in readStream() on kafka structured s...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16836
Pardon my ignorance, but does it not actually work?
If so, there is at least one more instance two examples down. And it'd be great if you could look for more occurrences all at once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org