[GitHub] ueshin commented on a change in pull request #23384: [SPARK-26443 ][CORE] Use ConfigEntry for hardcoded configs for history category.

[GitBox <gi...@apache.org>]

ueshin commented on a change in pull request #23384: [SPARK-26443 ][CORE] Use ConfigEntry for hardcoded configs for history category.
URL: https://github.com/apache/spark/pull/23384#discussion_r244312513
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
 ##########
 @@ -78,8 +78,8 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers
     Utils.deleteRecursively(storeDir)
     assert(storeDir.mkdir())
     val conf = new SparkConf()
-      .set("spark.history.fs.logDirectory", logDir)
-      .set("spark.history.fs.update.interval", "0")
+      .set(EVENT_LOG_DIR, logDir)
 
 Review comment:
   I think we can use the config entry as a key directly except for configs the string expression of which is more readable like `timeConf` or `bytesConf`. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org