You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/06/19 16:59:32 UTC

[Bug 58056] New: FastHttpDateFormat.formats - non-synchronised access to SimpleDateFormat

https://bz.apache.org/bugzilla/show_bug.cgi?id=58056

            Bug ID: 58056
           Summary: FastHttpDateFormat.formats - non-synchronised access
                    to SimpleDateFormat
           Product: Tomcat 9
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: sebb@apache.org

The array FastHttpDateFormat.formats contains several SimpleDateFormat entries.

These are passed to internalParseDate and used without synchronisation unless
the caller provides their own threadLocal array to the public method parseDate.

I've not checked to see whether parse is ever called with threadLocal == null,
but given that the code allows this, it really ought to synchronise the access
to the local SDF entries.

Also the parseDate Javadoc really ought to document the parameters...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 58056] FastHttpDateFormat.formats - non-synchronised access to SimpleDateFormat

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58056

Remy Maucherat <re...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Remy Maucherat <re...@apache.org> ---
The formats field was unused, so the code is removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org