[GitHub] [pinot] richardstartin commented on pull request #8034: remove consuming segment from `PartitionUpsertMetadataManager` to prevent memory leak

[GitBox <gi...@apache.org>]

richardstartin commented on pull request #8034:
URL: https://github.com/apache/pinot/pull/8034#issuecomment-1018730228


   > This shouldn't be required because when the segment is sealed and loaded again as ImmutableSegment, all the entries in the upsert metadata map should have already been replaced. This leak might happen only when user explicitly delete the consuming segment, but that will stall the realtime consumption and also mess up the upsert metadata, so I don't think we need to handle this scenario.
   
   What about when it's loaded on a different server?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org