[GitHub] [ignite] NSAmelchev commented on a change in pull request #8250: IGNITE-13008 Java thin client: Add compatibility tests

[GitBox <gi...@apache.org>]

NSAmelchev commented on a change in pull request #8250:
URL: https://github.com/apache/ignite/pull/8250#discussion_r514107546



##########
File path: modules/compatibility/src/test/java/org/apache/ignite/compatibility/clients/AbstractClientCompatibilityTest.java
##########
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.compatibility.clients;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.stream.Collectors;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.compatibility.testframework.junits.Dependency;
+import org.apache.ignite.compatibility.testframework.junits.IgniteCompatibilityAbstractTest;
+import org.apache.ignite.compatibility.testframework.junits.IgniteCompatibilityNodeRunner;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteVersionUtils;
+import org.apache.ignite.internal.util.GridJavaProcess;
+import org.apache.ignite.internal.util.typedef.X;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteInClosure;
+import org.apache.ignite.lang.IgniteProductVersion;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.multijvm.IgniteProcessProxy;
+import org.jetbrains.annotations.NotNull;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+/**
+ * Tests that current client version can connect to the server with specified version and
+ * specified client version can connect to the current server version.
+ */
+@RunWith(Parameterized.class)
+public abstract class AbstractClientCompatibilityTest extends IgniteCompatibilityAbstractTest {
+    /** Version 2.5.0. */
+    protected static final IgniteProductVersion VER_2_5_0 = IgniteProductVersion.fromString("2.5.0");
+
+    /** Version 2.7.0. */
+    protected static final IgniteProductVersion VER_2_7_0 = IgniteProductVersion.fromString("2.7.0");
+
+    /** Version 2.8.0. */
+    protected static final IgniteProductVersion VER_2_8_0 = IgniteProductVersion.fromString("2.8.0");
+
+    /** Version 2.9.0. */
+    protected static final IgniteProductVersion VER_2_9_0 = IgniteProductVersion.fromString("2.9.0");
+
+    /** Ignite versions to test. Note: Only released versions or current version should be included to this list. */
+    protected static final String[] TESTED_IGNITE_VERSIONS = new String[] {
+        "2.4.0",
+        "2.5.0",
+        "2.6.0",
+        "2.7.0",
+        "2.7.5",
+        "2.7.6",
+        "2.8.0",
+        "2.8.1",
+        "2.9.0",
+        IgniteVersionUtils.VER_STR
+    };
+
+    /** Parameters. */
+    @Parameterized.Parameters(name = "Version {0}")
+    public static Iterable<Object[]> versions() {
+        return Arrays.stream(TESTED_IGNITE_VERSIONS)
+            .map(v -> new Object[] {v})
+            .collect(Collectors.toList());
+    }
+
+    /** Old Ignite version. */
+    @Parameterized.Parameter
+    public String verFormatted;
+
+    /** */
+    protected IgniteProductVersion ver;
+
+    /** {@inheritDoc} */
+    @Override protected void beforeTest() throws Exception {
+        super.beforeTest();
+
+        ver = IgniteProductVersion.fromString(verFormatted);
+    }
+
+    /** {@inheritDoc} */
+    @Override protected @NotNull Collection<Dependency> getDependencies(String igniteVer) {
+        Collection<Dependency> dependencies = super.getDependencies(igniteVer);
+
+        dependencies.add(new Dependency("indexing", "ignite-indexing", false));
+
+        // Add corresponding H2 version.
+        if (ver.compareTo(VER_2_7_0) < 0)
+            dependencies.add(new Dependency("h2", "com.h2database", "h2", "1.4.195", false));
+
+        return dependencies;
+    }
+
+    /**
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testOldClientToCurrentServer() throws Exception {
+        try (Ignite ignite = startGrid(0)) {
+            initNode(ignite);
+
+            if (verFormatted.equals(IgniteVersionUtils.VER_STR))
+                testClient(verFormatted);
+            else {
+                String fileName = IgniteCompatibilityNodeRunner.storeToFile((IgniteInClosure<String>)this::testClient);
+
+                GridJavaProcess proc = GridJavaProcess.exec(
+                    RemoteClientRunner.class.getName(),
+                    IgniteVersionUtils.VER_STR + ' ' + fileName,
+                    log,
+                    log::info,
+                    null,
+                    null,
+                    getProcessProxyJvmArgs(verFormatted),
+                    null
+                );
+
+                try {
+                    GridTestUtils.waitForCondition(() -> !proc.getProcess().isAlive(), 5_000L);
+
+                    assertEquals(0, proc.getProcess().exitValue());
+                }
+                finally {
+                    if (proc.getProcess().isAlive())
+                        proc.kill();
+                }
+            }
+        }
+    }
+
+    /**
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testCurrentClientToOldServer() throws Exception {
+        IgniteProcessProxy proxy = null;
+
+        try {
+            if (verFormatted.equals(IgniteVersionUtils.VER_STR)) {
+                Ignite ignite = startGrid(0);
+
+                initNode(ignite);
+            }
+            else {
+                Ignite ignite = startGrid(1, verFormatted, this::processRemoteConfiguration, this::initNode);
+
+                proxy = IgniteProcessProxy.ignite(ignite.name());
+            }
+
+            testClient(verFormatted);
+        }
+        finally {
+            stopAllGrids();
+
+            if (proxy != null) {
+                Process proc = proxy.getProcess().getProcess();
+
+                // We should wait until process exits, or it can affect next tests.
+                GridTestUtils.waitForCondition(() -> !proc.isAlive(), 5_000L);

Review comment:
       The result of `waitForCondition` is ignored.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org