[GitHub] [activemq-artemis] haanhvu commented on pull request #3812: ARTEMIS-3057 Add min-free-disk-bytes feature

[GitBox <gi...@apache.org>]

haanhvu commented on pull request #3812:
URL: https://github.com/apache/activemq-artemis/pull/3812#issuecomment-950883567


   @clebertsuconic I got `BUILD SUCCESS` with `mvn -Pdev install -Derrorprone`
   
   But now I realize that my implementation lets the broker measure both max-disk-usage and min-free-disk-bytes at the same time. That can cause some problems:
   - What if max-disk-usage is violated but min-free-disk-bytes is not violated (or vice versa)? Will the broker block or not?
   - Why forces users to set two parameters for the same purpose?
   
   For the solution, I'm thinking of two options:
   - Allow only either max-disk-usage or min-free-disk-bytes activated. If going this route, we need two constructors for FileStoreMonitor.
   - Allow both max-disk-usage or min-free-disk-bytes activated, however only when both are violated the system will block. We can do this by editing the tick() method.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org