You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/11/04 20:39:39 UTC
Review Request 27586: Increase robustness when reading PEX-INFO
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-456
https://issues.apache.org/jira/browse/AURORA-456
Repository: aurora
Description
-------
This patch prevents aurora version from crashing when it is built with a different version of pants.
Diffs
-----
src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
Diff: https://reviews.apache.org/r/27586/diff/
Testing
-------
[tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:07
Aurora API version: APIVersion(major=3)
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:18
Aurora API version: APIVersion(major=3)
Thanks,
Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 4, 2014, 7:48 p.m., Joshua Cohen wrote:
> > Can you add a test case?
+1
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59812
-----------------------------------------------------------
On Nov. 4, 2014, 7:55 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 7:55 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59812
-----------------------------------------------------------
Can you add a test case?
- Joshua Cohen
On Nov. 4, 2014, 7:39 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 7:39 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59844
-----------------------------------------------------------
Ship it!
Master (9ef905a) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 4, 2014, 9:22 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 9:22 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
> src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b
> src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59840
-----------------------------------------------------------
src/test/python/apache/aurora/client/commands/test_version.py
<https://reviews.apache.org/r/27586/#comment101122>
Asserting on call count here is a pretty weak test. We could call print 4 times for any number of reasons, can we not verify that output matches what we'd expect given the mocked data from build info?
- Joshua Cohen
On Nov. 4, 2014, 9:22 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 9:22 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
> src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b
> src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review60060
-----------------------------------------------------------
Ship it!
Thanks! This is now on master:
$ git log -1 origin/master
commit 0ad2fcabb6444c2da9d156b0117ee8ae8e3b713f
Author: Zameer Manji <zm...@twopensource.com>
Date: Wed Nov 5 14:29:26 2014 -0800
Increase robustness when reading PEX-INFO
Bugs closed: AURORA-456
Reviewed at https://reviews.apache.org/r/27586/
- Bill Farner
On Nov. 5, 2014, 3:34 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 3:34 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
> src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b
> src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59927
-----------------------------------------------------------
Master (9847b7b) is red with this patch.
./build-support/jenkins/build.sh
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exit Log an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython>=2.6,<3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fast Run tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
- Aurora ReviewBot
On Nov. 5, 2014, 3:34 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 3:34 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
> src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b
> src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 7:34 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Improve tests.
Bugs: AURORA-456
https://issues.apache.org/jira/browse/AURORA-456
Repository: aurora
Description
-------
This patch prevents aurora version from crashing when it is built with a different version of pants.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b
src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION
Diff: https://reviews.apache.org/r/27586/diff/
Testing
-------
[tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:07
Aurora API version: APIVersion(major=3)
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:18
Aurora API version: APIVersion(major=3)
Thanks,
Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 1:22 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Add tests to cover different PEX-INFO formats.
Bugs: AURORA-456
https://issues.apache.org/jira/browse/AURORA-456
Repository: aurora
Description
-------
This patch prevents aurora version from crashing when it is built with a different version of pants.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b
src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION
Diff: https://reviews.apache.org/r/27586/diff/
Testing
-------
[tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:07
Aurora API version: APIVersion(major=3)
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:18
Aurora API version: APIVersion(major=3)
Thanks,
Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59816
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 4, 2014, 11:55 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 11:55 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59821
-----------------------------------------------------------
Master (9ef905a) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.help ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.logging ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... FAILURE
src.test.python.apache.aurora.client.config ..... SUCCESS
- Aurora ReviewBot
On Nov. 4, 2014, 7:55 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 7:55 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 11:55 a.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Catch BadZipFile exception.
Bugs: AURORA-456
https://issues.apache.org/jira/browse/AURORA-456
Repository: aurora
Description
-------
This patch prevents aurora version from crashing when it is built with a different version of pants.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
Diff: https://reviews.apache.org/r/27586/diff/
Testing
-------
[tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:07
Aurora API version: APIVersion(major=3)
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
Aurora client build info:
sha: d03187404dac583884a979dd302dd3cd36163c98
date: Tuesday Nov 04, 2014 11:39:18
Aurora API version: APIVersion(major=3)
Thanks,
Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59810
-----------------------------------------------------------
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/27586/#comment101114>
Can you catch BadZipfile here as well.
- Kevin Sweeney
On Nov. 4, 2014, 11:39 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 11:39 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-456
> https://issues.apache.org/jira/browse/AURORA-456
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch prevents aurora version from crashing when it is built with a different version of pants.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c
>
> Diff: https://reviews.apache.org/r/27586/diff/
>
>
> Testing
> -------
>
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> sha: d03187404dac583884a979dd302dd3cd36163c98
> date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
>
>
> Thanks,
>
> Zameer Manji
>
>