[jira] [Commented] (HIVE-7561) StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark

["Brock Noland (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082836#comment-14082836 ] 

Brock Noland commented on HIVE-7561:
------------------------------------

[~csun] this looks great!! Would you be able to post a Review Board item and then use the "Web Link" feature to link this JIRA to the RB item? Additionally, could we had some error message to these? e.g. "AssertionError: expected ...."

> StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark
> --------------------------------------------------------------------------
>
>                 Key: HIVE-7561
>                 URL: https://issues.apache.org/jira/browse/HIVE-7561
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>    Affects Versions: spark-branch
>            Reporter: Brock Noland
>            Assignee: Chao
>              Labels: StarterProject
>         Attachments: HIVE-7561-spark.patch
>
>
> Hive uses the "assert" keyword all over the place. The problem is that assertions are rarely enabled since they have to be specifically enabled. In the Spark code, e.g. GenSparkUtils, let's use Preconditions.*.



--
This message was sent by Atlassian JIRA
(v6.2#6252)