You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/21 08:51:59 UTC

[GitHub] [dubbo] guohao opened a new pull request #9084: [3.0-Triple] Add TransportObserver doc

guohao opened a new pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084


   ## What is the purpose of the change
   1. Add more docs for understanding
   2. Reactor some code for readable
   
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on a change in pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

EarthChen commented on a change in pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#discussion_r733618597



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -70,7 +70,7 @@ protected AbstractClientStream(URL url) {
                     + getConsumerModel().getServiceName() + "#" + getMethodName() +
                     " was canceled by local exception ", throwable);
             }
-            this.asTransportObserver().onReset(getHttp2Error(throwable));
+            this.asTransportObserver().onCancel(getHttp2Error(throwable));

Review comment:
       Should call `OutboundTransportObserver`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2168941) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **increase** coverage by `0.03%`.
   > The diff coverage is `52.80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.69%   64.73%   +0.03%     
     Complexity      311      311              
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50707      -15     
     Branches       7550     7549       -1     
   ============================================
   + Hits          32817    32826       +9     
   + Misses        14338    14306      -32     
   - Partials       3567     3575       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...o/rpc/protocol/tri/TripleClientRequestHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50UmVxdWVzdEhhbmRsZXIuamF2YQ==) | `75.00% <ø> (-1.20%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...2168941](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ccad4d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **decrease** coverage by `0.05%`.
   > The diff coverage is `45.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.46%   64.41%   -0.06%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50686      -37     
     Branches       7549     7521      -28     
   ============================================
   - Hits          32701    32648      -53     
   + Misses        14480    14470      -10     
   - Partials       3542     3568      +26     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.91% <40.00%> (-2.04%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [69 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...7ccad4d](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c3c4b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **decrease** coverage by `0.26%`.
   > The diff coverage is `52.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.69%   64.43%   -0.27%     
     Complexity      311      311              
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50714       -8     
     Branches       7550     7527      -23     
   ============================================
   - Hits          32817    32678     -139     
   - Misses        14338    14465     +127     
   - Partials       3567     3571       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [55 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ccad4d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.20%`.
   > The diff coverage is `45.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.67%   +0.20%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50721       -2     
     Branches       7549     7548       -1     
   ============================================
   + Hits          32701    32802     +101     
   + Misses        14480    14355     -125     
   - Partials       3542     3564      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.91% <40.00%> (-2.04%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [32 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...7ccad4d](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54ca501) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **decrease** coverage by `0.05%`.
   > The diff coverage is `45.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.46%   64.41%   -0.06%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50686      -37     
     Branches       7549     7521      -28     
   ============================================
   - Hits          32701    32647      -54     
   + Misses        14480    14468      -12     
   - Partials       3542     3571      +29     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.91% <33.33%> (-2.04%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [74 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...54ca501](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a361411) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.27%`.
   > The diff coverage is `49.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.74%   +0.27%     
   - Complexity      323      324       +1     
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50716       -7     
     Branches       7549     7549              
   ============================================
   + Hits          32701    32835     +134     
   + Misses        14480    14321     -159     
   - Partials       3542     3560      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `59.80% <ø> (+6.29%)` | :arrow_up: |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...a361411](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b297297) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.24%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.71%   +0.24%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50729       +6     
     Branches       7549     7549              
   ============================================
   + Hits          32701    32827     +126     
   + Misses        14480    14336     -144     
   - Partials       3542     3566      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `56.00% <60.00%> (-2.34%)` | :arrow_down: |
   | ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...b297297](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db1da26) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **increase** coverage by `0.03%`.
   > The diff coverage is `52.33%`.
   
   > :exclamation: Current head db1da26 differs from pull request most recent head 30c3c4b. Consider uploading reports for the commit 30c3c4b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.69%   64.73%   +0.03%     
     Complexity      311      311              
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50714       -8     
     Branches       7550     7549       -1     
   ============================================
   + Hits          32817    32828      +11     
   + Misses        14338    14320      -18     
   + Partials       3567     3566       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [30 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a14aff) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **decrease** coverage by `0.06%`.
   > The diff coverage is `47.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.46%   64.40%   -0.07%     
   + Complexity      323      322       -1     
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50687      -36     
     Branches       7549     7521      -28     
   ============================================
   - Hits          32701    32646      -55     
   + Misses        14480    14474       -6     
   - Partials       3542     3567      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `34.54% <33.33%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.57% <36.36%> (-2.39%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [69 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...2a14aff](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a14aff) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.22%`.
   > The diff coverage is `47.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.68%   +0.22%     
   - Complexity      323      325       +2     
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50722       -1     
     Branches       7549     7548       -1     
   ============================================
   + Hits          32701    32812     +111     
   + Misses        14480    14351     -129     
   - Partials       3542     3559      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `34.54% <33.33%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.57% <36.36%> (-2.39%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [31 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...2a14aff](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

EarthChen commented on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948558553


   Http2error seems to be useless for cancel. Consider removing it from the stream?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on a change in pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

EarthChen commented on a change in pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#discussion_r734181501



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -70,7 +70,7 @@ protected AbstractClientStream(URL url) {
                     + getConsumerModel().getServiceName() + "#" + getMethodName() +
                     " was canceled by local exception ", throwable);
             }
-            this.asTransportObserver().onCancel(getHttp2Error(throwable));
+            this.inboundTransportObserver().onCancel(getHttp2Error(throwable));

Review comment:
       When the client initiatively cancels here it should send RST




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a361411) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.27%`.
   > The diff coverage is `49.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.74%   +0.27%     
   - Complexity      323      324       +1     
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50716       -7     
     Branches       7549     7549              
   ============================================
   + Hits          32701    32838     +137     
   + Misses        14480    14318     -162     
   - Partials       3542     3560      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `59.80% <ø> (+6.29%)` | :arrow_up: |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | ... and [34 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...a361411](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2168941) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **increase** coverage by `0.04%`.
   > The diff coverage is `52.80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.69%   64.74%   +0.04%     
     Complexity      311      311              
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50707      -15     
     Branches       7550     7549       -1     
   ============================================
   + Hits          32817    32829      +12     
   + Misses        14338    14305      -33     
   - Partials       3567     3573       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...o/rpc/protocol/tri/TripleClientRequestHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50UmVxdWVzdEhhbmRsZXIuamF2YQ==) | `75.00% <ø> (-1.20%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...2168941](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54ca501) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **decrease** coverage by `0.01%`.
   > The diff coverage is `45.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.46%   64.45%   -0.02%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50721       -2     
     Branches       7549     7548       -1     
   ============================================
   - Hits          32701    32694       -7     
   + Misses        14480    14465      -15     
   - Partials       3542     3562      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.91% <33.33%> (-2.04%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [50 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...54ca501](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c3c4b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **increase** coverage by `0.00%`.
   > The diff coverage is `52.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##                3.0    #9084   +/-   ##
   =========================================
     Coverage     64.69%   64.70%           
   - Complexity      311      312    +1     
   =========================================
     Files          1177     1178    +1     
     Lines         50722    50714    -8     
     Branches       7550     7549    -1     
   =========================================
   - Hits          32817    32812    -5     
   + Misses        14338    14335    -3     
     Partials       3567     3567           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] guohao merged pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

guohao merged pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db1da26) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **decrease** coverage by `0.24%`.
   > The diff coverage is `52.33%`.
   
   > :exclamation: Current head db1da26 differs from pull request most recent head 30c3c4b. Consider uploading reports for the commit 30c3c4b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.69%   64.45%   -0.25%     
   + Complexity      311      310       -1     
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50679      -43     
     Branches       7550     7522      -28     
   ============================================
   - Hits          32817    32667     -150     
   - Misses        14338    14444     +106     
   - Partials       3567     3568       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [64 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a14aff) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.19%`.
   > The diff coverage is `47.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.66%   +0.19%     
   - Complexity      323      325       +2     
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50722       -1     
     Branches       7549     7548       -1     
   ============================================
   + Hits          32701    32801     +100     
   + Misses        14480    14358     -122     
   - Partials       3542     3563      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `34.54% <33.33%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.57% <36.36%> (-2.39%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [33 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...2a14aff](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54ca501) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.23%`.
   > The diff coverage is `45.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.70%   +0.23%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50721       -2     
     Branches       7549     7548       -1     
   ============================================
   + Hits          32701    32819     +118     
   + Misses        14480    14341     -139     
   - Partials       3542     3561      +19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.91% <33.33%> (-2.04%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [33 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...54ca501](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c3c4b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **decrease** coverage by `0.19%`.
   > The diff coverage is `52.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.69%   64.50%   -0.20%     
   - Complexity      311      312       +1     
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50714       -8     
     Branches       7550     7549       -1     
   ============================================
   - Hits          32817    32711     -106     
   - Misses        14338    14444     +106     
   + Partials       3567     3559       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [45 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ccad4d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.00%`.
   > The diff coverage is `45.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##                3.0    #9084   +/-   ##
   =========================================
     Coverage     64.46%   64.47%           
     Complexity      323      323           
   =========================================
     Files          1177     1179    +2     
     Lines         50723    50721    -2     
     Branches       7549     7548    -1     
   =========================================
     Hits          32701    32701           
   + Misses        14480    14460   -20     
   - Partials       3542     3560   +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.91% <40.00%> (-2.04%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [41 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...7ccad4d](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b297297) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.24%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.71%   +0.24%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50729       +6     
     Branches       7549     7549              
   ============================================
   + Hits          32701    32829     +128     
   + Misses        14480    14335     -145     
   - Partials       3542     3565      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `56.00% <60.00%> (-2.34%)` | :arrow_down: |
   | ... and [34 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...b297297](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b297297) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.02%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.49%   +0.02%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50729       +6     
     Branches       7549     7549              
   ============================================
   + Hits          32701    32716      +15     
   + Misses        14480    14451      -29     
   - Partials       3542     3562      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `56.00% <60.00%> (-2.34%)` | :arrow_down: |
   | ... and [45 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...b297297](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c3c4b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **increase** coverage by `0.01%`.
   > The diff coverage is `52.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.69%   64.71%   +0.01%     
   - Complexity      311      312       +1     
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50714       -8     
     Branches       7550     7549       -1     
   ============================================
   + Hits          32817    32820       +3     
   + Misses        14338    14327      -11     
     Partials       3567     3567              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [31 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a14aff) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **decrease** coverage by `0.00%`.
   > The diff coverage is `47.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.46%   64.46%   -0.01%     
   - Complexity      323      324       +1     
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50722       -1     
     Branches       7549     7548       -1     
   ============================================
   - Hits          32701    32699       -2     
   + Misses        14480    14463      -17     
   - Partials       3542     3560      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `34.54% <33.33%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.57% <36.36%> (-2.39%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...2a14aff](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

EarthChen commented on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948556000


   The client cancel the listener should call `OutboundTransportObserver#onReset`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54ca501) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.20%`.
   > The diff coverage is `45.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.46%   64.67%   +0.20%     
     Complexity      323      323              
   ============================================
     Files          1177     1179       +2     
     Lines         50723    50721       -2     
     Branches       7549     7548       -1     
   ============================================
   + Hits          32701    32802     +101     
   + Misses        14480    14355     -125     
   - Partials       3542     3564      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.80% <0.00%> (-0.84%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `42.85% <10.00%> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `28.91% <33.33%> (-2.04%)` | :arrow_down: |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.03% <34.88%> (-0.36%)` | :arrow_down: |
   | [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `32.00% <40.00%> (-26.34%)` | :arrow_down: |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...pc/protocol/tri/UnaryInboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlJbmJvdW5kVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `57.14% <57.14%> (ø)` | |
   | ... and [32 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...54ca501](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db1da26) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **decrease** coverage by `0.20%`.
   > The diff coverage is `52.33%`.
   
   > :exclamation: Current head db1da26 differs from pull request most recent head 30c3c4b. Consider uploading reports for the commit 30c3c4b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.69%   64.49%   -0.21%     
   + Complexity      311      310       -1     
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50714       -8     
     Branches       7550     7549       -1     
   ============================================
   - Hits          32817    32710     -107     
   - Misses        14338    14442     +104     
   + Partials       3567     3562       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [41 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db1da26) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **increase** coverage by `0.01%`.
   > The diff coverage is `52.33%`.
   
   > :exclamation: Current head db1da26 differs from pull request most recent head 30c3c4b. Consider uploading reports for the commit 30c3c4b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   + Coverage     64.69%   64.71%   +0.01%     
     Complexity      311      311              
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50714       -8     
     Branches       7550     7549       -1     
   ============================================
   + Hits          32817    32818       +1     
   + Misses        14338    14329       -9     
     Partials       3567     3567              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `44.44% <53.19%> (+0.85%)` | :arrow_up: |
   | ... and [29 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...30c3c4b](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6b9630) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bf3548d50162aff07b3dcc216174a806646f174b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf3548d) will **increase** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##                3.0    #9084   +/-   ##
   =========================================
     Coverage     64.46%   64.47%           
   - Complexity      323      326    +3     
   =========================================
     Files          1177     1177           
     Lines         50723    50724    +1     
     Branches       7549     7549           
   =========================================
   + Hits          32701    32704    +3     
   - Misses        14480    14481    +1     
   + Partials       3542     3539    -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...protocol/tri/AbstractChannelTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDaGFubmVsVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `60.00% <0.00%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `59.39% <0.00%> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <0.00%> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.36% <0.00%> (-0.23%)` | :arrow_down: |
   | [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `66.66% <0.00%> (ø)` | |
   | [...ubbo/rpc/protocol/tri/ServerTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.21% <0.00%> (+4.25%)` | :arrow_up: |
   | [.../common/threadpool/serial/SerializingExecutor.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zZXJpYWwvU2VyaWFsaXppbmdFeGVjdXRvci5qYXZh) | `70.37% <0.00%> (-7.41%)` | :arrow_down: |
   | [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `86.79% <0.00%> (-5.67%)` | :arrow_down: |
   | [.../registry/zookeeper/ZookeeperServiceDiscovery.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS96b29rZWVwZXIvWm9va2VlcGVyU2VydmljZURpc2NvdmVyeS5qYXZh) | `83.52% <0.00%> (-2.36%)` | :arrow_down: |
   | [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `90.32% <0.00%> (-1.62%)` | :arrow_down: |
   | ... and [10 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf3548d...b6b9630](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on a change in pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

EarthChen commented on a change in pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#discussion_r733473180



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ClientTransportObserver.java
##########
@@ -68,8 +68,8 @@ protected void doOnData(byte[] data, boolean endStream) {
     }
 
     @Override
-    protected void doOnReset(Http2Error http2Error) {
-        streamChannel.writeAndFlush(new DefaultHttp2ResetFrame(http2Error))
+    protected void doOnCancel(GrpcStatus status) {

Review comment:
       Can `GrpcStatus` be removed if we always send cancel?

##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractStream.java
##########
@@ -420,10 +420,10 @@ public Metadata getTrailers() {
         }
 
         @Override
-        public void onReset(Http2Error http2Error) {
+        public void onCancel(GrpcStatus status) {
             if (getState().allowSendReset()) {
                 getState().setResetSend();

Review comment:
       Remove setResetSend() method ,This state is already set in transport

##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ServerTransportObserver.java
##########
@@ -81,8 +81,8 @@ protected void doOnData(byte[] data, boolean endStream) {
     }
 
     @Override
-    protected void doOnReset(Http2Error http2Error) {
-        ctx.writeAndFlush(new DefaultHttp2ResetFrame(http2Error))
+    protected void doOnCancel(GrpcStatus status) {
+        ctx.writeAndFlush(new DefaultHttp2ResetFrame(Http2Error.CANCEL))

Review comment:
       like pre.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] EarthChen commented on a change in pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

EarthChen commented on a change in pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#discussion_r733594313



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ServerStream.java
##########
@@ -198,9 +205,7 @@ public void onComplete() {
             if (getMethodDescriptor().getRpcType() == MethodDescriptor.RpcType.SERVER_STREAM) {

Review comment:
       Replace `getMethodDescriptor().isServerStream()`

##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/UnaryInboundTransportObserver.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.rpc.protocol.tri;
+
+abstract class UnaryInboundTransportObserver extends InboundTransportObserver implements TransportObserver {
+    protected static final String DUPLICATED_DATA = "Duplicated data";
+
+    private byte[] data;
+
+    public byte[] getData() {
+        return data;
+    }
+
+    protected abstract void onError(GrpcStatus status);
+
+    public void onCancel(GrpcStatus status) {

Review comment:
       Is cancel necessary here?

##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractStream.java
##########
@@ -266,7 +265,7 @@ public void subscribe(AbstractChannelTransportObserver observer) {
 
     @Override
     public TransportObserver asTransportObserver() {

Review comment:
       Change the method name is better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9084: [3.0-Triple] Add TransportObserver doc

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9084:
URL: https://github.com/apache/dubbo/pull/9084#issuecomment-948435224


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9084](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2168941) into [3.0](https://codecov.io/gh/apache/dubbo/commit/3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfa4f5) will **decrease** coverage by `0.22%`.
   > The diff coverage is `52.80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9084/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9084      +/-   ##
   ============================================
   - Coverage     64.69%   64.47%   -0.23%     
     Complexity      311      311              
   ============================================
     Files          1177     1178       +1     
     Lines         50722    50671      -51     
     Branches       7550     7521      -29     
   ============================================
   - Hits          32817    32670     -147     
   - Misses        14338    14428      +90     
   - Partials       3567     3573       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...o/rpc/protocol/tri/TripleClientRequestHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50UmVxdWVzdEhhbmRsZXIuamF2YQ==) | `75.00% <ø> (-1.20%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUHJvdG9jb2wuamF2YQ==) | `89.74% <ø> (ø)` | |
   | [...protocol/tri/TripleHttp2ClientResponseHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJDbGllbnRSZXNwb25zZUhhbmRsZXIuamF2YQ==) | `33.92% <25.00%> (-0.62%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `27.14% <37.50%> (-3.63%)` | :arrow_down: |
   | [...bo/rpc/protocol/tri/OutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvT3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `52.94% <38.88%> (ø)` | |
   | [...bbo/rpc/protocol/tri/InboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSW5ib3VuZFRyYW5zcG9ydE9ic2VydmVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [.../protocol/tri/ClientOutboundTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50T3V0Ym91bmRUcmFuc3BvcnRPYnNlcnZlci5qYXZh) | `65.78% <50.00%> (ø)` | |
   | [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `31.32% <50.00%> (+0.37%)` | :arrow_up: |
   | [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.43% <50.00%> (+0.22%)` | :arrow_up: |
   | ... and [79 more](https://codecov.io/gh/apache/dubbo/pull/9084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bfa4f5...2168941](https://codecov.io/gh/apache/dubbo/pull/9084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org