You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/16 12:07:57 UTC

[GitHub] [tinkerpop] spmallette commented on pull request #1700: gremlin-go: support per-request arguments in bytecode

spmallette commented on PR #1700:
URL: https://github.com/apache/tinkerpop/pull/1700#issuecomment-1157585246

   > It extracts the whitelisted set of per-request options in makeBytecodeRequests() and adds them to the bytecode request without modifying the generated bytecode.
   
   I don't think that's a bad approach and I can't think of any problems with this offhand. Perhaps python (other GLVs) should be done that way too. Generally speaking, it's nicer when the bytecode matches what was originally constructed. 
   
   Normally I'd suggest a CHANGELOG entry or even upgrade docs, but since the Go GLV isn't officially released yet, we can forego that as you've basically just added a feature that should have been present anyway from the start. 😄 
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org