You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/16 06:06:07 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request #15187: style: Database connect UI Polish - Step 3
lyndsiWilliams opened a new pull request #15187:
URL: https://github.com/apache/superset/pull/15187
### SUMMARY
Added styling to match the [figma specifications](https://www.figma.com/file/NbuTOMaUdv2GCBoDyihdLw/Database-Connection?node-id=1698%3A401419) for step 3 of the database connection form.
### SCREENSHOTS
#### BASIC
<img width="499" alt="basic" src="https://user-images.githubusercontent.com/55605634/122165791-55572200-ce3e-11eb-9cdc-2263c326d05e.png">
#### ADVANCED
<img width="499" alt="advanced" src="https://user-images.githubusercontent.com/55605634/122165910-820b3980-ce3e-11eb-990e-909bd1aef6db.png">
#### SQLLAB
<img width="499" alt="sqllab" src="https://user-images.githubusercontent.com/55605634/122165920-86375700-ce3e-11eb-8af3-2b5452f69671.png">
#### PERFORMANCE
<img width="499" alt="performance" src="https://user-images.githubusercontent.com/55605634/122165927-89324780-ce3e-11eb-825b-e56c8bedac4f.png">
#### SECURITY
<img width="499" alt="security-1" src="https://user-images.githubusercontent.com/55605634/122165935-8d5e6500-ce3e-11eb-9ae9-bbedd55c8e5c.png">
<img width="499" alt="security-2" src="https://user-images.githubusercontent.com/55605634/122165942-8f282880-ce3e-11eb-8beb-d509bca9a94d.png">
#### OTHER
<img width="499" alt="other" src="https://user-images.githubusercontent.com/55605634/122165952-93544600-ce3e-11eb-8736-4e093489aaf5.png">
### TESTING INSTRUCTIONS
From the Superset home page:
- Hover over "Data" in the upper navigation bar
- Click "Database"
- Click the "+ Database" button below the navigation bar and to the right
- Select the `SQLite` database
- Observe the styling of "Step 3" of the database connection form
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org