You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by ok2c <gi...@git.apache.org> on 2018/12/01 10:41:57 UTC
[GitHub] httpcomponents-core pull request #98: SSLIOSession: Add `connectTimeout` con...
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/98#discussion_r238059606
--- Diff: httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java ---
@@ -243,7 +243,8 @@ public void execute(final SSLIOSession sslSession) {
}
}
- }))) {
+ },
+ null))) {
--- End diff --
@rschmitt Do we really need an extra constructor parameter if it is always set to `null`? Otherwise looks good.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org