You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/07/11 06:47:07 UTC
(texera) 01/01: refactor(amber): remove dead WorkflowWorker.handleActorCommand (#6305)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-6305-157a8605c5b3a7f45cbb4b6f6ec8d71c45a91cd8
in repository https://gitbox.apache.org/repos/asf/texera.git
commit d825a8415479771e5dba6adcf6040a61b28557ff
Author: Xinyuan Lin <xi...@uci.edu>
AuthorDate: Fri Jul 10 23:46:46 2026 -0700
refactor(amber): remove dead WorkflowWorker.handleActorCommand (#6305)
### What changes were proposed in this PR?
Removes the dead `handleActorCommand` method from `WorkflowWorker`. It
is a `Receive` whose body is a bare `println(c)`, it is not part of the
actor's `receive` chain (`receive = super.receive orElse
handleDirectInvocation orElse handleTriggerClosure`), and it has no
callers — the live `handleActorCommand` is a separate method on
`DPThread`. Deleting it removes a debug leftover and raises coverage by
removal rather than cementing dead code with a test.
### Any related issues, documentation, discussions?
Closes #6304. Follow-up to a review comment by @mengw15 on #6289.
### How was this PR tested?
No new tests — this only deletes unreachable code. Verified locally
(Java 17): the amber module compiles, `WorkerSpec` (which exercises
`WorkflowWorker`) passes, and `scalafixAll --check` is clean (the
`ActorCommand` import remains used via `ActorCommandElement`).
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
---------
Signed-off-by: Xinyuan Lin <xi...@uci.edu>
Co-authored-by: probe <pr...@x>
Co-authored-by: Copilot Autofix powered by AI <17...@users.noreply.github.com>
---
.../texera/amber/engine/architecture/worker/WorkflowWorker.scala | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/WorkflowWorker.scala b/amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/WorkflowWorker.scala
index 51bf59b2f1..99f10050f3 100644
--- a/amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/WorkflowWorker.scala
+++ b/amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/WorkflowWorker.scala
@@ -127,14 +127,9 @@ class WorkflowWorker(
t.closure(this)
}
- def handleActorCommand: Receive = {
- case c: ActorCommand =>
- println(c)
- }
-
override def preRestart(reason: Throwable, message: Option[Any]): Unit = {
super.preRestart(reason, message)
- logger.error(s"Encountered fatal error, worker is shutting done.", reason)
+ logger.error(s"Encountered fatal error, worker is shutting down.", reason)
postStop()
}