You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/08 15:36:44 UTC
[GitHub] [sling-org-apache-sling-starter] rombert commented on a change in pull request #13: SLING-9695 Added options for datastore
rombert commented on a change in pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#discussion_r485013649
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
Review comment:
Any particular reason to add this step? I think it's simpler to not copy it, but use it directly in its configured location.
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
+3) Copy either the feature archive (*.far) or individual set of feature.json files to the project folder
- mvn clean install
-
-in the current directory.
-2) Start Sling backed by an Oak SegmentStore with
+Example 1: Start an instance using the launcher specifying a feature archive (.far)
+This example uses the aggregate `oak_tar_far` as defined in the pom.xml
- java -jar target/dependency/org.apache.sling.feature.launcher.jar -f target/slingfeature-tmp/feature-oak_tar.json
-
-3) Browse Sling in:
+ java -jar org.apache.sling.feature.launcher.jar -f org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far
+
+Example 2: Start an instance using the launcher specifying an aggregate feature file.
+This example uses the aggregate `feature-oak_tar.json` as defined in the pom.xml
+
+ java -jar org.apache.sling.feature.launcher.jar -f feature-oak_tar.json
Review comment:
You are missing the `target/slingfeature-tmp` prefix here.
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
+3) Copy either the feature archive (*.far) or individual set of feature.json files to the project folder
- mvn clean install
-
-in the current directory.
-2) Start Sling backed by an Oak SegmentStore with
+Example 1: Start an instance using the launcher specifying a feature archive (.far)
+This example uses the aggregate `oak_tar_far` as defined in the pom.xml
- java -jar target/dependency/org.apache.sling.feature.launcher.jar -f target/slingfeature-tmp/feature-oak_tar.json
-
-3) Browse Sling in:
+ java -jar org.apache.sling.feature.launcher.jar -f org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far
Review comment:
You are missing the `target/slingfeature-tmp` prefix here.
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
+3) Copy either the feature archive (*.far) or individual set of feature.json files to the project folder
- mvn clean install
-
-in the current directory.
-2) Start Sling backed by an Oak SegmentStore with
+Example 1: Start an instance using the launcher specifying a feature archive (.far)
+This example uses the aggregate `oak_tar_far` as defined in the pom.xml
- java -jar target/dependency/org.apache.sling.feature.launcher.jar -f target/slingfeature-tmp/feature-oak_tar.json
-
-3) Browse Sling in:
+ java -jar org.apache.sling.feature.launcher.jar -f org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far
+
+Example 2: Start an instance using the launcher specifying an aggregate feature file.
+This example uses the aggregate `feature-oak_tar.json` as defined in the pom.xml
+
+ java -jar org.apache.sling.feature.launcher.jar -f feature-oak_tar.json
+
+Example 3: Start an instance using the launcher specifying a set feature files.
+
+ java -jar org.apache.sling.feature.launcher.jar -f feature-base.json,feature-boot.json,....
Review comment:
Perhaps it would be better to point to the feature model launcher documentation instead?
##########
File path: pom.xml
##########
@@ -127,7 +127,7 @@
<classifier>oak_mongo_far</classifier>
<includeClassifier>oak_mongo</includeClassifier>
</archive>
- </archives>
Review comment:
Can you please drop these whitespace-only changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org