Re: [PR] [Draft] Add GENERATE_ARRAY function [pinot]

["dttung2905 (via GitHub)" <gi...@apache.org>]

dttung2905 commented on PR #11834:
URL: https://github.com/apache/pinot/pull/11834#issuecomment-1807258883

   Hi @xiangfu0 sorry I was really busy with works ( pre-Christmas period :sweat_smile: ). I just fixed the unit test for the failed test `testCalciteFunctionMapAllRegistered` by whitelisting it under `IGNORED_FUNCTION_NAMES`. The next time CI is run, the tests should pass.
   
   Is there anything I'm mising before the review ? Do I need to 
   - add the test for scalar function changes in `pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java`. I look up the other scalar function but can't find any test for those. cmiiw :thinking: 
   - remove the changes in `pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java` as we have implemented the batch function already?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org