[GitHub] [skywalking] LIU-WEI-git edited a comment on issue #7713: [Bug] The methods of H2EventQueryDAO doesn't sort the data by Event.START_TIME

[GitBox <gi...@apache.org>]

LIU-WEI-git edited a comment on issue #7713:
URL: https://github.com/apache/skywalking/issues/7713#issuecomment-919666431


   [EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/query/EventQueryDAO.java#L73) and [ESEventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/ESEventQueryDAO.java#L128) use the pagination ("limit" and "from") of the first condition. However, [H2EventQueryDAO](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c91b0d0/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java#L115) adopts the [sum of limit size of all condition](https://github.com/apache/skywalking/blob/94623f283139e31484979205ef7c14d73c9
 1b0d0/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java#L100) with out offset. Should I modify H2EventQueryDAO according to the other two? @wu-sheng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org