You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2021/08/19 07:27:12 UTC

[flink] branch master updated: [FLINK-22217][runtime][logging] Add quotes around job name

This is an automated email from the ASF dual-hosted git repository.

chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 16cf155  [FLINK-22217][runtime][logging] Add quotes around job name
16cf155 is described below

commit 16cf155f21a32170e79611bd8803a477d098e4c2
Author: David Moravek <dm...@apache.org>
AuthorDate: Thu Aug 19 09:26:43 2021 +0200

    [FLINK-22217][runtime][logging] Add quotes around job name
---
 .../java/org/apache/flink/runtime/dispatcher/Dispatcher.java  |  5 +++--
 .../java/org/apache/flink/runtime/jobmaster/JobMaster.java    | 11 +++++++----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
index 0fd1377..4782d08 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
@@ -297,7 +297,8 @@ public abstract class Dispatcher extends PermanentlyFencedRpcEndpoint<Dispatcher
 
     @Override
     public CompletableFuture<Acknowledge> submitJob(JobGraph jobGraph, Time timeout) {
-        log.info("Received JobGraph submission {} ({}).", jobGraph.getJobID(), jobGraph.getName());
+        log.info(
+                "Received JobGraph submission '{}' ({}).", jobGraph.getName(), jobGraph.getJobID());
 
         try {
             if (isDuplicateJob(jobGraph.getJobID())) {
@@ -371,7 +372,7 @@ public abstract class Dispatcher extends PermanentlyFencedRpcEndpoint<Dispatcher
     }
 
     private CompletableFuture<Acknowledge> internalSubmitJob(JobGraph jobGraph) {
-        log.info("Submitting job {} ({}).", jobGraph.getJobID(), jobGraph.getName());
+        log.info("Submitting job '{}' ({}).", jobGraph.getName(), jobGraph.getJobID());
 
         final CompletableFuture<Acknowledge> persistAndRunFuture =
                 waitForTerminatingJob(jobGraph.getJobID(), jobGraph, this::persistAndRunJob)
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java b/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
index 4464bd9..d21df82 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
@@ -289,7 +289,7 @@ public class JobMaster extends PermanentlyFencedRpcEndpoint<JobMasterId>
         final String jobName = jobGraph.getName();
         final JobID jid = jobGraph.getJobID();
 
-        log.info("Initializing job {} ({}).", jobName, jid);
+        log.info("Initializing job '{}' ({}).", jobName, jid);
 
         resourceManagerLeaderRetriever =
                 highAvailabilityServices.getResourceManagerLeaderRetriever();
@@ -395,13 +395,16 @@ public class JobMaster extends PermanentlyFencedRpcEndpoint<JobMasterId>
     /** Suspend the job and shutdown all other services including rpc. */
     @Override
     public CompletableFuture<Void> onStop() {
-        log.info("Stopping the JobMaster for job {}({}).", jobGraph.getName(), jobGraph.getJobID());
+        log.info(
+                "Stopping the JobMaster for job '{}' ({}).",
+                jobGraph.getName(),
+                jobGraph.getJobID());
 
         // make sure there is a graceful exit
         return stopJobExecution(
                         new FlinkException(
                                 String.format(
-                                        "Stopping JobMaster for job %s(%s).",
+                                        "Stopping JobMaster for job '%s' (%s).",
                                         jobGraph.getName(), jobGraph.getJobID())))
                 .exceptionally(
                         exception -> {
@@ -868,7 +871,7 @@ public class JobMaster extends PermanentlyFencedRpcEndpoint<JobMasterId>
         startJobMasterServices();
 
         log.info(
-                "Starting execution of job {} ({}) under job master id {}.",
+                "Starting execution of job '{}' ({}) under job master id {}.",
                 jobGraph.getName(),
                 jobGraph.getJobID(),
                 getFencingToken());