You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by jo...@gmail.com on 2009/06/25 23:45:39 UTC

Re: dynamic-height Chrome fix

http://codereview.appspot.com/88070/diff/1/2
File
features/src/main/javascript/features/dynamic-height/dynamic-height.js
(right):

http://codereview.appspot.com/88070/diff/1/2#newcode49
Line 49: value.match(/^([0-9]+)px$/);
does "px" always show up? Might some rendering cases yield values like:
* 123
* 123em
* 123 px

...in other words, perhaps we could just drop the textual suffix and $.

http://codereview.appspot.com/88070