You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Yongqiang He <he...@gmail.com> on 2011/08/25 00:23:39 UTC
Review Request: get_privilege does not get user level privilege and should
return emptylist instead of null
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1646/
-----------------------------------------------------------
Review request for hive and Ning Zhang.
Summary
-------
get_privilege does not get user level privilege and should return emptylist instead of null
This addresses bug HIVE-2405.
https://issues.apache.org/jira/browse/HIVE-2405
Diffs
-----
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1161232
trunk/ql/src/test/queries/clientpositive/authorization_7.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/authorization_7.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1646/diff
Testing
-------
Thanks,
Yongqiang
Re: Review Request: get_privilege does not get user level privilege and
should return emptylist instead of null
Posted by Ning Zhang <nz...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1646/#review1632
-----------------------------------------------------------
Just a minor clarification. Otherwise looks good to me.
trunk/ql/src/test/queries/clientpositive/authorization_7.q
<https://reviews.apache.org/r/1646/#comment3671>
is it necessary to set this after GRANT ALL ...?
- Ning
On 2011-08-24 22:23:39, Yongqiang He wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1646/
> -----------------------------------------------------------
>
> (Updated 2011-08-24 22:23:39)
>
>
> Review request for hive and Ning Zhang.
>
>
> Summary
> -------
>
> get_privilege does not get user level privilege and should return emptylist instead of null
>
>
> This addresses bug HIVE-2405.
> https://issues.apache.org/jira/browse/HIVE-2405
>
>
> Diffs
> -----
>
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1161232
> trunk/ql/src/test/queries/clientpositive/authorization_7.q PRE-CREATION
> trunk/ql/src/test/results/clientpositive/authorization_7.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1646/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiang
>
>
Re: Review Request: get_privilege does not get user level privilege and
should return emptylist instead of null
Posted by Yongqiang He <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1646/#review1774
-----------------------------------------------------------
trunk/ql/src/test/queries/clientpositive/authorization_7.q
<https://reviews.apache.org/r/1646/#comment4051>
yes. what we want to do is to test the global privilege. The first command is to grant a global privilege, and after that do test with that.
- Yongqiang
On 2011-08-24 22:23:39, Yongqiang He wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1646/
> -----------------------------------------------------------
>
> (Updated 2011-08-24 22:23:39)
>
>
> Review request for hive and Ning Zhang.
>
>
> Summary
> -------
>
> get_privilege does not get user level privilege and should return emptylist instead of null
>
>
> This addresses bug HIVE-2405.
> https://issues.apache.org/jira/browse/HIVE-2405
>
>
> Diffs
> -----
>
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1161232
> trunk/ql/src/test/queries/clientpositive/authorization_7.q PRE-CREATION
> trunk/ql/src/test/results/clientpositive/authorization_7.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1646/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiang
>
>