[jira] [Commented] (YUNIKORN-766) driver/executor get hang occasionally if the applicationId is defined

["Weiwei Yang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390022#comment-17390022 ] 

Weiwei Yang commented on YUNIKORN-766:
--------------------------------------

Good catch, it makes sense to have a "stable" way to fetch AppID, +1 for the fix.

There are small things need to be fixed in the PR, commented in github, pls check. thank you!

> driver/executor get hang occasionally if the applicationId is defined
> ---------------------------------------------------------------------
>
>                 Key: YUNIKORN-766
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-766
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Chia-Ping Tsai
>            Priority: Major
>              Labels: pull-request-available
>
> The code used to get applicationId is shown below.
> // application ID can be defined in labels
>  for name, value := range pod.Labels {
>  // application ID can be defined as a label
>  if name == constants.LabelApplicationID {
>  return value, nil
>  }
> // if a pod for spark already provided appID, reuse it
>  if name == constants.SparkLabelAppID {
>  return value, nil
>  }
>  }
> The iteration order is random so it could get application id from 'spark-app-selector' rather than `applicationId` (even though `applicationId` is defined by users)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org