[jira] Closed: (DERBY-1734) Simplify building of SystemColumn array in CatalogRowFactory implementations.

["Daniel John Debrunner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel John Debrunner closed DERBY-1734.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.4.0.0

All CatalogRowFactory.buildColumnList() methods use the new style mechanism.

> Simplify building of SystemColumn array in CatalogRowFactory  implementations.
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-1734
>                 URL: https://issues.apache.org/jira/browse/DERBY-1734
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Daniel John Debrunner
>            Assignee: Daniel John Debrunner
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>
> The implementations of CatalogRowFactory.buildColumnList() can be simplified in a number of ways:
>   1) precision & scale are always passed in as zero and can be removed
>    2) adding static factory methods to SystemColumnImpl would ease the building of the arrays by not requiring the additional redundant arguments the constructor call forces today, e.g. max length i snot required to create an INTEGER column.
>     3) The column's position is not required to be stored in the SytstemColumn class, it's defined by the position in the array
> 4) arrays can be built using
>           new SystemColumn[] { ... }
>      syntax instead of the existing
>             columnList[0] = ...
>             columnList[1] = ...
>       or
>             columnList[index++] = ...
>             columnList[index++] = ...
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.