You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2018/03/31 22:08:18 UTC
[royale-asjs] branch feature/alert-changes created (now 7971c64)
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a change to branch feature/alert-changes
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.
at 7971c64 Alert Changes: * Alert rearrange parameters to match Flex Alert show method (and Jewel Alert) * CloseEvent default detail change from 4 (OK) to 8 (CANCEL). A close button seems more like a CANCEL than a OK action
This branch includes the following new commits:
new 7971c64 Alert Changes: * Alert rearrange parameters to match Flex Alert show method (and Jewel Alert) * CloseEvent default detail change from 4 (OK) to 8 (CANCEL). A close button seems more like a CANCEL than a OK action
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
--
To stop receiving notification emails like this one, please contact
carlosrovira@apache.org.
[royale-asjs] 01/01: Alert Changes: * Alert rearrange parameters to
match Flex Alert show method (and Jewel Alert) * CloseEvent default detail
change from 4 (OK) to 8 (CANCEL). A close button seems more like a CANCEL
than a OK action
Posted by ca...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch feature/alert-changes
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 7971c641bc5c37e453ddabd0f413aa2e57e95b19
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Sun Apr 1 00:08:10 2018 +0200
Alert Changes:
* Alert rearrange parameters to match Flex Alert show method (and Jewel Alert)
* CloseEvent default detail change from 4 (OK) to 8 (CANCEL). A close button seems more like a CANCEL than a OK action
---
.../Basic/src/main/royale/org/apache/royale/html/Alert.as | 2 +-
.../src/main/royale/org/apache/royale/events/CloseEvent.as | 10 ++++++++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as
index 69469e9..721ee01 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as
@@ -114,7 +114,7 @@ package org.apache.royale.html
* @playerversion AIR 2.6
* @productversion Royale 0.0
*/
- static public function show( message:String, parent:Object, title:String="", flags:uint=Alert.OK ) : Alert
+ static public function show( message:String, title:String="", parent:Object, flags:uint=Alert.OK ) : Alert
{
var alert:Alert = new Alert();
alert.message = message;
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/events/CloseEvent.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/events/CloseEvent.as
index a245083..597f123 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/events/CloseEvent.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/events/CloseEvent.as
@@ -32,8 +32,13 @@ package org.apache.royale.events
{
public static const CLOSE:String = "close";
+ /**
+ * constructor
+ *
+ * detail by default is like an Alert.CANCEL
+ */
public function CloseEvent(type:String, bubbles:Boolean=false, cancelable:Boolean=false,
- detail:uint = 0x000004):void
+ detail:uint = 0x000008):void
{
super(type, bubbles, cancelable);
@@ -41,7 +46,8 @@ package org.apache.royale.events
}
/**
- * Identifies the button in the popped up control that was clicked. This property is for controls with multiple * buttons. The Alert control sets this property to one of the following constants:
+ * Identifies the button in the popped up control that was clicked. This property is for controls with multiple
+ * buttons. The Alert control sets this property to one of the following constants:
*
* Alert.YES
* Alert.NO
--
To stop receiving notification emails like this one, please contact
carlosrovira@apache.org.