You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/20 11:23:17 UTC

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2800: [Improve][DOC] Perfect the connector v2 doc

Hisoka-X commented on code in PR #2800:
URL: https://github.com/apache/incubator-seatunnel/pull/2800#discussion_r975225675


##########
seatunnel-connectors-v2/README.zh.md:
##########
@@ -61,4 +61,4 @@ if (Boundedness.BOUNDED.equals(context.getBoundedness())) {
 #### 我应该实现SinkCommitter还是SinkAggregatedCommitter?
 当前版本推荐将实现SinkAggregatedCommitter作为首选,可以在Flink/Spark中提供较强的一致性保证,同时commit应该要实现幂等性,保存引擎重试能够正常运作。
 ## 实现
-所有的Connector实现都应该在`seatunnel-connectors/seatunnel-connectors-seatuunel`模块下,现阶段可参考的示例均在此模块下。
\ No newline at end of file
+所有的Connector实现都应该在`seatunnel-connectors/seatunnel-connectors-seatuunel`模块下,现阶段可参考的示例均在此模块下。

Review Comment:
   ```suggestion
   所有的Connector实现都应该在`seatunnel-connectors-v2`模块下,现阶段可参考的示例均在此模块下。
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org