You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/24 17:50:41 UTC

[GitHub] [kafka] jolshan commented on pull request #12342: KAFKA-10888: Revert #12049 f7db603

jolshan commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165801074

   I'm a little confused by the results here. 
   > Results:
   Commit: https://github.com/apache/kafka/commit/e3202b99999ef4c63aab2e5ab049978704282792 (the parent of the problematic commit)
   TPut: 118k±1k
   Commit: https://github.com/apache/kafka/commit/f7db6031b84a136ad0e257df722b20faa7c37b8a (https://github.com/apache/kafka/pull/12049)
   TPut: 106k±1k
   (every commit that we have tested from trunk after https://github.com/apache/kafka/commit/f7db6031b84a136ad0e257df722b20faa7c37b8a is also around 106k)
   This PR, reverting https://github.com/apache/kafka/commit/f7db6031b84a136ad0e257df722b20faa7c37b8a
   TPut: 116k±1k
   
   it seems like reverting this commit doesn't help that much to improve perf. I'm also wondering what benchmark you are running here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org