You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2023/03/22 01:45:09 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #4391: [Bugfix][DAG]fix test case error
liugddx opened a new pull request, #4391:
URL: https://github.com/apache/incubator-seatunnel/pull/4391
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4391: [Bugfix][Zeta] Fix job dag parse
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4391:
URL: https://github.com/apache/incubator-seatunnel/pull/4391#issuecomment-1478963440
#4369 has passed all test cases. It seems ths pull request is not make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #4391: [Bugfix][DAG]fix test case error
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #4391:
URL: https://github.com/apache/incubator-seatunnel/pull/4391#issuecomment-1478808365
Change the collection order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx closed pull request #4391: [Bugfix][Zeta] Fix job dag parse
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx closed pull request #4391: [Bugfix][Zeta] Fix job dag parse
URL: https://github.com/apache/incubator-seatunnel/pull/4391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #4391: [Bugfix][Zeta] Fix job dag parse
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #4391:
URL: https://github.com/apache/incubator-seatunnel/pull/4391#issuecomment-1479029546
I found a strange problem, the test case fails but passes normally
https://github.com/apache/incubator-seatunnel/actions/runs/4485929422/jobs/7889738474?pr=4369#step:4:22169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4391: [Bugfix][Zeta] Fix job dag parse
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4391:
URL: https://github.com/apache/incubator-seatunnel/pull/4391#issuecomment-1478963773
> #4369 has passed all test cases. It seems ths pull request is not make sense.
cc @EricJoy2048 @hailin0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #4391: [Bugfix][Zeta] Fix job dag parse
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #4391:
URL: https://github.com/apache/incubator-seatunnel/pull/4391#issuecomment-1479030292
> 
>
> I found a strange problem, the test case fails but passes normally
>
> https://github.com/apache/incubator-seatunnel/actions/runs/4485929422/jobs/7889738474?pr=4369#step:4:22169
@TyrantLucifer @EricJoy2048 @Hisoka-X @hailin0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #4391: [Bugfix][Zeta] Fix job dag parse
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #4391:
URL: https://github.com/apache/incubator-seatunnel/pull/4391#issuecomment-1478980416
> > #4369 has passed all test cases. It seems ths pull request is not make sense.
>
> cc @EricJoy2048 @hailin0
I search for the next, as if no test log. Is this test not printing any logs or not executing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org