[GitHub] [incubator-streampipes] yangdh1225 commented on a change in pull request #48: flink 1.13 rest port config & Keep kafka consumer group for Pipeline action and sepas

[GitBox <gi...@apache.org>]

yangdh1225 commented on a change in pull request #48:
URL: https://github.com/apache/incubator-streampipes/pull/48#discussion_r685630742



##########
File path: streampipes-pipeline-management/src/main/java/org/apache/streampipes/manager/execution/http/PipelineExecutor.java
##########
@@ -107,7 +108,7 @@ private void updateGroupIds(InvocableStreamPipesEntity entity) {
             .filter(is -> is.getEventGrounding().getTransportProtocol() instanceof KafkaTransportProtocol)
             .map(is -> is.getEventGrounding().getTransportProtocol())
             .map(KafkaTransportProtocol.class::cast)
-            .forEach(tp -> tp.setGroupId(UUID.randomUUID().toString()));
+            .forEach(tp -> tp.setGroupId(pipeline.getName() + "-" + MD5.crypt(tp.getElementId())));

Review comment:
       The pipeline name is used instead of id, just to make it easier to identify in Kafka monitoring. Certainly if the UI interface does not check special characters, such as spaces, surely we should use id to generate group id.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org